Merge pull request #1602 from pateljannat/negative-marking-in-quiz

feat: negative marking in quiz

lms/lms/doctype/lms_quiz/lms_quiz.json

@@ -17,8 +17,10 @@
   "duration",
   "section_break_tzbu",
   "shuffle_questions",
-  "column_break_clsh",
   "limit_questions_to",
+  "column_break_clsh",
+  "enable_negative_marking",
+  "marks_to_cut",
   "section_break_sbjx",
   "questions",
   "section_break_3",
@@ -134,6 +136,19 @@
    "fieldname": "duration",
    "fieldtype": "Data",
    "label": "Duration (in minutes)"
+  },
+  {
+   "default": "0",
+   "fieldname": "enable_negative_marking",
+   "fieldtype": "Check",
+   "label": "Enable Negative Marking"
+  },
+  {
+   "default": "1",
+   "depends_on": "enable_negative_marking",
+   "fieldname": "marks_to_cut",
+   "fieldtype": "Int",
+   "label": "Marks To Cut"
   }
  ],
  "grid_page_length": 50,
@@ -144,8 +159,8 @@
    "link_fieldname": "quiz"
   }
  ],
- "modified": "2025-04-07 15:03:48.525458",
- "modified_by": "Administrator",
+ "modified": "2025-06-27 20:00:15.660323",
+ "modified_by": "sayali@frappe.io",
  "module": "LMS",
  "name": "LMS Quiz",
  "owner": "Administrator",

lms/lms/doctype/lms_quiz/lms_quiz.py

@@ -44,6 +44,11 @@ class LMSQuiz(Document):
 				frappe.throw(_("All questions should have the same marks if the limit is set."))
 
 	def calculate_total_marks(self):
+		if len(self.questions) == 0:
+			self.total_marks = 0
+			self.passing_percentage = 100
+			return
+
 		if self.limit_questions_to:
 			self.total_marks = sum(
 				question.marks for question in self.questions[: cint(self.limit_questions_to)]
@@ -102,11 +107,19 @@ def quiz_summary(quiz, results):
 	quiz_details = frappe.db.get_value(
 		"LMS Quiz",
 		quiz,
-		["total_marks", "passing_percentage", "lesson", "course"],
+		[
+			"name",
+			"total_marks",
+			"passing_percentage",
+			"lesson",
+			"course",
+			"enable_negative_marking",
+			"marks_to_cut",
+		],
 		as_dict=1,
 	)
 
-	data = process_results(results, quiz)
+	data = process_results(results, quiz_details)
 	results = data["results"]
 	score = data["score"]
 	is_open_ended = data["is_open_ended"]
@@ -129,14 +142,14 @@ def quiz_summary(quiz, results):
 	}
 
 
-def process_results(results, quiz):
+def process_results(results, quiz_details):
 	score = 0
 	is_open_ended = False
 
 	for result in results:
 		question_details = frappe.db.get_value(
 			"LMS Quiz Question",
-			{"parent": quiz, "question": result["question_name"]},
+			{"parent": quiz_details.name, "question": result["question_name"]},
 			["question", "marks", "question_detail", "type"],
 			as_dict=1,
 		)
@@ -154,7 +167,11 @@ def process_results(results, quiz):
 			else:
 				result["is_correct"] = 0
 
-			marks = question_details.marks if correct else 0
+			if correct:
+				marks = question_details.marks
+			else:
+				marks = -quiz_details.marks_to_cut if quiz_details.enable_negative_marking else 0
+
 			result["marks"] = marks
 			score += marks