Merge pull request #1631 from pateljannat/issues-118

fix: misc issues

lms/install.py

@@ -1,11 +1,11 @@
 import frappe
 from frappe.desk.page.setup_wizard.setup_wizard import add_all_roles_to
-from lms.lms.api import give_dicussions_permission
+from lms.lms.api import give_discussions_permission
 
 
 def after_install():
 	create_batch_source()
-	give_dicussions_permission()
+	give_discussions_permission()
 
 
 def after_sync():

lms/lms/api.py

@@ -1011,7 +1011,30 @@ def delete_course(course):
 	frappe.delete_doc("LMS Course", course)
 
 
-def give_dicussions_permission():
+@frappe.whitelist()
+def delete_batch(batch):
+	frappe.db.delete("LMS Batch Enrollment", {"batch": batch})
+	frappe.db.delete("Batch Course", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Assessment", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Batch Timetable", {"parent": batch, "parenttype": "LMS Batch"})
+	frappe.db.delete("LMS Batch Feedback", {"batch": batch})
+	delete_batch_discussions(batch)
+	frappe.db.delete("LMS Batch", batch)
+
+
+def delete_batch_discussions(batch):
+	topics = frappe.get_all(
+		"Discussion Topic",
+		{"reference_doctype": "LMS Batch", "reference_docname": batch},
+		pluck="name",
+	)
+
+	for topic in topics:
+		frappe.db.delete("Discussion Reply", {"topic": topic})
+		frappe.db.delete("Discussion Topic", topic)
+
+
+def give_discussions_permission():
 	doctypes = ["Discussion Topic", "Discussion Reply"]
 	roles = ["LMS Student", "Course Creator", "Moderator", "Batch Evaluator"]
 	for doctype in doctypes:

lms/patches/v2_0/give_discussions_permissions.py

@@ -1,6 +1,6 @@
 import frappe
-from lms.lms.api import give_dicussions_permission
+from lms.lms.api import give_discussions_permission
 
 
 def execute():
-	give_dicussions_permission()
+	give_discussions_permission()