From 5970540a99c83cd2cce7d0cb3904585755978cea Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 29 Jan 2026 15:24:20 +0530
Subject: [PATCH] feat: lesson completion rate in course dashboard

---
 .../src/pages/Courses/CourseDashboard.vue     | 90 +++++++++++++++----
 frontend/src/pages/Courses/Courses.vue        |  2 +-
 lms/lms/api.py                                | 33 +++++--
 3 files changed, 100 insertions(+), 25 deletions(-)

diff --git a/frontend/src/pages/Courses/CourseDashboard.vue b/frontend/src/pages/Courses/CourseDashboard.vue
index f6571e3f..a802ae59 100644
--- a/frontend/src/pages/Courses/CourseDashboard.vue
+++ b/frontend/src/pages/Courses/CourseDashboard.vue
@@ -187,14 +187,46 @@
 						/>
 					</div>
 				</div>
-				{{ lessonProgress.data }}
-				<div v-if="lessonProgress.data?.length" class="border rounded-lg p-4">
-					<div class="text-ink-gray-5 mb-4">
-						{{ __('Lesson Completion') }}
+				<div
+					v-if="lessonProgress.data?.length"
+					class="border rounded-lg pt-4 px-4"
+				>
+					<div class="flex items-center justify-between mb-4">
+						<div class="text-ink-gray-5">
+							{{ __('Lesson Completion') }}
+						</div>
+						<Select
+							:options="lessonProgressSortingOptions"
+							@update:modelValue="(value: string) => updateLessonProgress(value)"
+							:placeholder="__('Sort by')"
+							class="!w-32"
+						/>
+					</div>
+					<div class="divide-y max-h-[43vh] overflow-y-auto">
+						<div
+							v-for="progress in lessonProgress.data"
+							class="flex justify-between text-sm py-2 my-1"
+						>
+							<div class="">
+								<span class="mr-3 text-xs">
+									{{ progress.chapter_idx }}.{{ progress.idx }}
+								</span>
+								<span>
+									{{ progress.title }}
+								</span>
+							</div>
+							<Tooltip :text="progress.completion_count">
+								<div>
+									{{
+										Math.ceil(
+											(progress.completion_count / course.data?.enrollments) *
+												100
+										)
+									}}%
+								</div>
+							</Tooltip>
+						</div>
 					</div>
-					<!-- <div v-for="progress in lessonProgress.data">
-						{{ progress }}
-					</div> -->
 				</div>
 			</div>
 		</div>
@@ -212,6 +244,7 @@ import {
 	createListResource,
 	createResource,
 	dayjs,
+	Dropdown,
 	ECharts,
 	FormControl,
 	ListView,
@@ -220,10 +253,11 @@ import {
 	ListRows,
 	ListRow,
 	ListRowItem,
+	Select,
 	Tooltip,
 } from 'frappe-ui'
 import { computed, ref, watch } from 'vue'
-import { Plus, Star } from 'lucide-vue-next'
+import { ChevronDown, Plus, Star } from 'lucide-vue-next'
 import { formatAmount } from '@/utils'
 import colors from '@/utils/frappe-ui-colors.json'
 import CourseEnrollmentModal from '@/pages/Courses/CourseEnrollmentModal.vue'
@@ -280,16 +314,19 @@ const lessonProgress = createResource({
 	auto: true,
 })
 
-/* const lessonProgress = createListResource({
-	doctype: 'LMS Course Progress',
-	filters: {
-		course: props.course.data?.name,
-		status: 'Complete',
-	},
-	fields: ['lesson', `count(name) as completed_count`],
-	groupBy: 'lesson',
-	auto: true,
-}) */
+const updateLessonProgress = (value: string) => {
+	if (value == 'completion_rate') {
+		lessonProgress.data?.sort((a: any, b: any) => {
+			const rateA = a.completion_count / (props.course.data?.enrollments || 1)
+			const rateB = b.completion_count / (props.course.data?.enrollments || 1)
+			return rateB - rateA
+		})
+	} else if (value == 'index') {
+		lessonProgress.data?.sort((a: any, b: any) => {
+			return a.chapter_idx - b.chapter_idx || a.idx - b.idx
+		})
+	}
+}
 
 watch([searchFilter], () => {
 	let filterApplied = false
@@ -340,4 +377,21 @@ const progressColumns = computed(() => {
 		},
 	]
 })
+
+const lessonProgressSortingOptions = [
+	{
+		label: __('Lesson Index'),
+		value: 'index',
+		onClick() {
+			updateLessonProgress('index')
+		},
+	},
+	{
+		label: __('Completion Rate'),
+		value: 'completion_rate',
+		onClick() {
+			updateLessonProgress('completion_rate')
+		},
+	},
+]
 </script>
diff --git a/frontend/src/pages/Courses/Courses.vue b/frontend/src/pages/Courses/Courses.vue
index d6fdc168..0bd81158 100644
--- a/frontend/src/pages/Courses/Courses.vue
+++ b/frontend/src/pages/Courses/Courses.vue
@@ -5,7 +5,7 @@
 		<Breadcrumbs :items="breadcrumbs" />
 
 		<Dropdown
-			placement="start"
+			placement="right"
 			side="bottom"
 			v-if="canCreateCourse()"
 			:options="[
diff --git a/lms/lms/api.py b/lms/lms/api.py
index 9b3371e3..aceeb257 100644
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -27,6 +27,7 @@ from frappe.utils import (
 	now,
 )
 from frappe.utils.response import Response
+from pypika import functions as fn
 
 from lms.lms.doctype.course_lesson.course_lesson import save_progress
 from lms.lms.utils import (
@@ -2060,11 +2061,31 @@ def get_lesson_completion_stats(course):
 	if "Course Creator" not in roles and "Moderator" not in roles:
 		frappe.throw(_("You do not have permission to access lesson completion stats."))
 
-	lesson_progress = frappe.get_list(
-		"LMS Course Progress",
-		{"course": course, "status": "Complete"},
-		["lesson", "COUNT(name) as completion_count"],
-		group_by="lesson",
+	CourseProgress = frappe.qb.DocType("LMS Course Progress")
+	LessonReference = frappe.qb.DocType("Lesson Reference")
+	ChapterReference = frappe.qb.DocType("Chapter Reference")
+	Lesson = frappe.qb.DocType("Course Lesson")
+
+	rows = (
+		frappe.qb.from_(CourseProgress)
+		.join(LessonReference)
+		.on(CourseProgress.lesson == LessonReference.lesson)
+		.join(ChapterReference)
+		.on(LessonReference.parent == ChapterReference.chapter)
+		.join(Lesson)
+		.on(CourseProgress.lesson == Lesson.name)
+		.select(
+			LessonReference.idx,
+			ChapterReference.idx.as_("chapter_idx"),
+			CourseProgress.lesson,
+			Lesson.title,
+			Lesson.name.as_("lesson_name"),
+			fn.Count(CourseProgress.name).as_("completion_count"),
+		)
+		.where((CourseProgress.course == course) & (CourseProgress.status == "Complete"))
+		.groupby(CourseProgress.lesson)
+		.orderby(ChapterReference.idx, LessonReference.idx)
+		.run(as_dict=True)
 	)
 
-	return lesson_progress
+	return rows