From 641d729bd136f403b713bb28614586f5f00044cf Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Mon, 16 Feb 2026 12:17:13 +0530
Subject: [PATCH] refactor: student batch dashboard

---
 .../src/components/Modals/EvaluationModal.vue |   3 +
 .../src/components/UpcomingEvaluations.vue    |   4 +-
 frontend/src/pages/Batches/BatchDetail.vue    |   3 +-
 frontend/src/pages/Batches/BatchForm.vue      |  86 +++++++-----
 frontend/src/pages/Batches/BatchOverview.vue  |   4 +-
 .../components/AdminBatchDashboard.vue        |  14 +-
 .../pages/Batches/components/Assessments.vue  |   2 +-
 .../pages/Batches/components/BatchCourses.vue |   2 +-
 .../Batches/components/BatchDashboard.vue     | 129 ++++++++++++++++--
 .../Batches/components/BatchFeedback.vue      |  36 +++--
 lms/lms/doctype/lms_batch/lms_batch.json      |  48 ++++---
 lms/lms/utils.py                              |  19 ++-
 12 files changed, 248 insertions(+), 102 deletions(-)

diff --git a/frontend/src/components/Modals/EvaluationModal.vue b/frontend/src/components/Modals/EvaluationModal.vue
index cbc86f99..afb1916d 100644
--- a/frontend/src/components/Modals/EvaluationModal.vue
+++ b/frontend/src/components/Modals/EvaluationModal.vue
@@ -55,6 +55,9 @@
 						</div>
 					</div>
 				</div>
+				<div v-else-if="!evaluation.course" class="text-ink-gray-7">
+					{{ __('Please select a course to view available slots.') }}
+				</div>
 				<div v-else class="text-ink-red-3">
 					{{ __('No slots available for the selected course.') }}
 				</div>
diff --git a/frontend/src/components/UpcomingEvaluations.vue b/frontend/src/components/UpcomingEvaluations.vue
index 1424979f..62582926 100644
--- a/frontend/src/components/UpcomingEvaluations.vue
+++ b/frontend/src/components/UpcomingEvaluations.vue
@@ -5,7 +5,7 @@
 				{{ __('Upcoming Evaluations') }}
 			</div>
 			<Button v-if="canScheduleEvals" @click="openEvalModal">
-				{{ __('Schedule Evaluation') }}
+				{{ __('Schedule') }}
 			</Button>
 		</div>
 		<div
@@ -31,7 +31,7 @@
 		<div v-if="upcoming_evals.data?.length">
 			<div
 				class="grid gap-4"
-				:class="forHome ? 'grid-cols-1 md:grid-cols-2' : 'grid-cols-3'"
+				:class="forHome ? 'grid-cols-1 md:grid-cols-2' : 'grid-cols-1'"
 			>
 				<div v-for="evl in upcoming_evals.data">
 					<div class="border text-ink-gray-7 rounded-md p-3">
diff --git a/frontend/src/pages/Batches/BatchDetail.vue b/frontend/src/pages/Batches/BatchDetail.vue
index 52bd5b6c..41cf027d 100644
--- a/frontend/src/pages/Batches/BatchDetail.vue
+++ b/frontend/src/pages/Batches/BatchDetail.vue
@@ -75,6 +75,7 @@
 </template>
 <script setup>
 import {
+	ClipboardPen,
 	Laptop,
 	List,
 	Mail,
@@ -166,7 +167,7 @@ const updateTabs = () => {
 	if (isAdmin.value) {
 		addToTabs('Dashboard', markRaw(AdminBatchDashboard), TrendingUp)
 	} else if (isStudent.value) {
-		addToTabs('Dashboard', markRaw(StudentBatchDashboard), null)
+		addToTabs('Dashboard', markRaw(StudentBatchDashboard), ClipboardPen)
 	}
 	addToTabs('Classes', markRaw(LiveClass), Laptop)
 	addToTabs('Announcements', markRaw(Announcements), Mail)
diff --git a/frontend/src/pages/Batches/BatchForm.vue b/frontend/src/pages/Batches/BatchForm.vue
index 77286a82..55f8ccea 100644
--- a/frontend/src/pages/Batches/BatchForm.vue
+++ b/frontend/src/pages/Batches/BatchForm.vue
@@ -2,26 +2,6 @@
 	<div class="">
 		<div class="grid grid-cols-[3fr,2fr]">
 			<div v-if="batchDetail.doc" class="py-5 h-[88vh] overflow-y-auto">
-				<div class="px-5 pb-5 space-y-5 border-b mb-5">
-					<div class="grid grid-cols-1 md:grid-cols-3 gap-5">
-						<FormControl
-							v-model="batchDetail.doc.published"
-							type="checkbox"
-							:label="__('Published')"
-						/>
-						<FormControl
-							v-model="batchDetail.doc.allow_self_enrollment"
-							type="checkbox"
-							:label="__('Allow Self Enrollment')"
-						/>
-						<FormControl
-							v-model="batchDetail.doc.certification"
-							type="checkbox"
-							:label="__('Certification')"
-						/>
-					</div>
-				</div>
-
 				<div class="px-5 pb-5 space-y-5 border-b mb-5">
 					<div class="text-lg text-ink-gray-9 font-semibold mb-4">
 						{{ __('Details') }}
@@ -29,6 +9,11 @@
 
 					<div class="grid grid-cols-1 md:grid-cols-2 gap-5">
 						<div class="space-y-5">
+							<FormControl
+								v-model="batchDetail.doc.published"
+								type="checkbox"
+								:label="__('Published')"
+							/>
 							<FormControl
 								v-model="batchDetail.doc.title"
 								:label="__('Title')"
@@ -58,6 +43,11 @@
 							/>
 						</div>
 						<div class="space-y-5">
+							<FormControl
+								v-model="batchDetail.doc.allow_self_enrollment"
+								type="checkbox"
+								:label="__('Allow Self Enrollment')"
+							/>
 							<FormControl
 								v-model="batchDetail.doc.start_time"
 								:label="__('Session Start Time')"
@@ -91,6 +81,35 @@
 					</div>
 				</div>
 
+				<div class="px-5 pb-5 space-y-5 border-b mb-5">
+					<div class="text-lg text-ink-gray-9 font-semibold mb-4">
+						{{ __('Certification') }}
+					</div>
+					<div class="grid grid-cols-1 md:grid-cols-2 gap-5 items-start">
+						<div class="flex flex-col space-y-5">
+							<FormControl
+								v-model="batchDetail.doc.evaluation"
+								type="checkbox"
+								:label="__('Evaluation')"
+							/>
+							<FormControl
+								v-if="batchDetail.doc.evaluation"
+								v-model="batchDetail.doc.evaluation_end_date"
+								:label="__('Evaluation End Date')"
+								type="date"
+								class="mb-4"
+							/>
+						</div>
+						<div>
+							<FormControl
+								v-model="batchDetail.doc.certification"
+								type="checkbox"
+								:label="__('Certification')"
+							/>
+						</div>
+					</div>
+				</div>
+
 				<div class="px-5 pb-5 space-y-5 border-b mb-5">
 					<div class="grid grid-cols-1 md:grid-cols-2 gap-5">
 						<div class="space-y-5">
@@ -110,9 +129,15 @@
 								:onCreate="(close) => openSettings('Evaluators', close)"
 								:filters="{ ignore_user_type: 1 }"
 							/>
+							<Uploader
+								v-model="batchDetail.doc.video_link"
+								:label="__('Preview Video')"
+								type="video"
+								:required="false"
+							/>
 						</div>
 						<div>
-							<label class="block text-sm text-ink-gray-5 mb-1">
+							<label class="block text-sm text-ink-gray-5 mb-2">
 								{{ __('Batch Details') }}
 								<span class="text-ink-red-3">*</span>
 							</label>
@@ -139,7 +164,7 @@
 							/>
 							<Link
 								doctype="Email Template"
-								:label="__('Email Template')"
+								:label="__('Enrollment Confirmation Email Template')"
 								v-model="batchDetail.doc.confirmation_email_template"
 								:onCreate="
 									(value, close) => {
@@ -147,6 +172,8 @@
 									}
 								"
 							/>
+						</div>
+						<div class="space-y-5">
 							<Link
 								doctype="LMS Zoom Settings"
 								:label="__('Zoom Account')"
@@ -158,20 +185,6 @@
 								"
 							/>
 						</div>
-						<div class="space-y-5">
-							<FormControl
-								v-model="batchDetail.doc.evaluation_end_date"
-								:label="__('Evaluation End Date')"
-								type="date"
-								class="mb-4"
-							/>
-							<Uploader
-								v-model="batchDetail.doc.video_link"
-								:label="__('Preview Video')"
-								type="video"
-								:required="false"
-							/>
-						</div>
 					</div>
 				</div>
 
@@ -350,6 +363,7 @@ const updateBatchData = () => {
 		'paid_batch',
 		'allow_self_enrollment',
 		'certification',
+		'evaluation',
 	]
 	for (let idx in checkboxes) {
 		let key = checkboxes[idx]
diff --git a/frontend/src/pages/Batches/BatchOverview.vue b/frontend/src/pages/Batches/BatchOverview.vue
index cacba3bf..918ffe7a 100644
--- a/frontend/src/pages/Batches/BatchOverview.vue
+++ b/frontend/src/pages/Batches/BatchOverview.vue
@@ -32,7 +32,7 @@
 				<BatchOverlay :batch="batch" />
 			</div>
 		</div>
-		<div v-if="batch.data.courses.length">
+		<div v-if="courses.data?.length">
 			<div class="flex items-center mt-10">
 				<div class="text-2xl font-semibold text-ink-gray-9">
 					{{ __('Courses') }}
@@ -40,7 +40,7 @@
 			</div>
 			<div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-8 mt-5">
 				<div
-					v-if="batch.data.courses"
+					v-if="courses.data?.length"
 					v-for="course in courses.data"
 					:key="course.course"
 				>
diff --git a/frontend/src/pages/Batches/components/AdminBatchDashboard.vue b/frontend/src/pages/Batches/components/AdminBatchDashboard.vue
index 45091163..789b28f2 100644
--- a/frontend/src/pages/Batches/components/AdminBatchDashboard.vue
+++ b/frontend/src/pages/Batches/components/AdminBatchDashboard.vue
@@ -20,7 +20,7 @@
 			<NumberChartGraph
 				class="border rounded-md"
 				:title="__('Assessments')"
-				:value="assessmentCount.data || 0"
+				:value="batch?.data?.assessments?.length || 0"
 			/>
 		</div>
 
@@ -198,15 +198,6 @@ const props = defineProps<{
 	batch: { [key: string]: any } | null
 }>()
 
-const assessmentCount = createResource({
-	url: 'lms.lms.utils.get_batch_assessment_count',
-	cache: ['batch_assessment_count', props.batch?.data?.name],
-	params: {
-		batch: props.batch?.data?.name,
-	},
-	auto: true,
-})
-
 const chartData = createResource({
 	url: 'lms.lms.utils.get_batch_chart_data',
 	cache: ['batch_chart_data', props.batch?.data?.name],
@@ -276,6 +267,7 @@ const studentColumns = computed(() => {
 const showProgressChart = computed(
 	() =>
 		students.data?.length &&
-		(props.batch?.data?.courses?.length || assessmentCount.data)
+		(props.batch?.data?.courses?.length ||
+			props.batch?.data?.assessments?.length)
 )
 </script>
diff --git a/frontend/src/pages/Batches/components/Assessments.vue b/frontend/src/pages/Batches/components/Assessments.vue
index 3cd82f0d..7e2c7200 100644
--- a/frontend/src/pages/Batches/components/Assessments.vue
+++ b/frontend/src/pages/Batches/components/Assessments.vue
@@ -1,7 +1,7 @@
 <template>
 	<div>
 		<div class="flex items-center justify-between mb-4">
-			<div class="text-lg text-ink-gray-9 font-semibold">
+			<div class="text-ink-gray-9 font-semibold">
 				{{ __('Assessments') }}
 			</div>
 			<Button v-if="canAddAssessments()" @click="showModal = true">
diff --git a/frontend/src/pages/Batches/components/BatchCourses.vue b/frontend/src/pages/Batches/components/BatchCourses.vue
index f6488aa3..6f7917fe 100644
--- a/frontend/src/pages/Batches/components/BatchCourses.vue
+++ b/frontend/src/pages/Batches/components/BatchCourses.vue
@@ -1,7 +1,7 @@
 <template>
 	<div>
 		<div class="flex items-center justify-between mb-4">
-			<div class="text-lg text-ink-gray-9 font-semibold">
+			<div class="text-ink-gray-9 font-semibold">
 				{{ __('Courses') }}
 			</div>
 			<Button v-if="isAdmin()" @click="openCourseModal()">
diff --git a/frontend/src/pages/Batches/components/BatchDashboard.vue b/frontend/src/pages/Batches/components/BatchDashboard.vue
index 9fb03cc9..39182d67 100644
--- a/frontend/src/pages/Batches/components/BatchDashboard.vue
+++ b/frontend/src/pages/Batches/components/BatchDashboard.vue
@@ -1,19 +1,101 @@
 <template>
-	<div class="space-y-10 mt-5 w-[75%] mx-auto">
-		<UpcomingEvaluations
-			:batch="batch.data.name"
-			:endDate="batch.data.evaluation_end_date"
-			:courses="batch.data.courses"
-		/>
-		<BatchCourses :batch="batch" />
-		<Assessments :batch="batch.data.name" />
-		<div class="grid grid-cols-2 gap-10"></div>
+	<div class="h-[88vh]">
+		<div class="grid grid-cols-[2fr,1fr] gap-5">
+			<div class="p-5">
+				<div class="mb-8 space-y-2">
+					<div class="text-lg font-semibold">
+						{{ __('Curriculum') }}
+					</div>
+					<div class="text-ink-gray-7">
+						{{
+							__(
+								"As a part of this batch's curriculum you will have to complete the following courses and assessments."
+							)
+						}}
+					</div>
+				</div>
+				<div class="space-y-10">
+					<div>
+						<div class="font-semibold mb-4">
+							{{ __('Courses') }}
+						</div>
+						<ListView
+							v-if="batch.data?.courses?.length"
+							:columns="courseColumns"
+							:rows="batch.data?.courses"
+							row-key="name"
+							class="border rounded-lg"
+							:options="{
+								showTooltip: false,
+								selectable: user.data?.is_student ? false : true,
+								getRowRoute: (row) => ({
+									name: 'CourseDetail',
+									params: { courseName: row.course },
+								}),
+							}"
+						>
+							<ListHeader
+								class="mb-2 grid items-center space-x-4 rounded-none rounded-t bg-surface-gray-2 p-2"
+							>
+							</ListHeader>
+							<ListRows>
+								<ListRow
+									:row="row"
+									v-for="row in batch.data?.courses"
+									class="!rounded-none text-sm"
+								>
+									<template #default="{ column, item }">
+										<ListRowItem :item="row[column.key]" :align="column.align">
+											<div v-if="column.key === 'progress'">
+												{{ getProgress(row.course) }}%
+											</div>
+											<div v-else>
+												{{ row[column.key] }}
+											</div>
+										</ListRowItem>
+									</template>
+								</ListRow>
+							</ListRows>
+						</ListView>
+						<div v-else class="text-ink-gray-7">
+							{{ __('No courses added to this batch') }}
+						</div>
+					</div>
+					<!-- <BatchCourses :batch="batch" /> -->
+					<Assessments :batch="batch.data.name" />
+				</div>
+			</div>
+			<div class="border-l h-[88vh] divide-y">
+				<div v-if="batch.data?.evaluation" class="p-4 mb-5">
+					<UpcomingEvaluations
+						:batch="batch.data.name"
+						:endDate="batch.data.evaluation_end_date"
+						:courses="batch.data.courses"
+					/>
+				</div>
+				<div class="p-5">
+					<BatchFeedback :batch="batch.data?.name" />
+				</div>
+			</div>
+		</div>
 	</div>
 </template>
 <script setup>
-import UpcomingEvaluations from '@/components/UpcomingEvaluations.vue'
+import { inject } from 'vue'
+import {
+	createListResource,
+	ListView,
+	ListHeader,
+	ListRows,
+	ListRow,
+	ListRowItem,
+} from 'frappe-ui'
 import Assessments from '@/pages/Batches/components/Assessments.vue'
 import BatchCourses from '@/pages/Batches/components/BatchCourses.vue'
+import BatchFeedback from '@/pages/Batches/components/BatchFeedback.vue'
+import UpcomingEvaluations from '@/components/UpcomingEvaluations.vue'
+
+const user = inject('$user')
 
 const props = defineProps({
 	batch: {
@@ -25,4 +107,31 @@ const props = defineProps({
 		default: false,
 	},
 })
+
+const progressList = createListResource({
+	doctype: 'LMS Enrollment',
+	filters: {
+		member: user.data?.name,
+		course: ['in', props.batch.data?.courses?.map((c) => c.course)],
+	},
+	fields: ['course', 'progress', 'name'],
+	auto: true,
+})
+
+const getProgress = (course) => {
+	const progress = progressList.data?.find((p) => p.course === course)
+	return progress ? Math.round(progress.progress) : 0
+}
+
+const courseColumns = [
+	{
+		key: 'title',
+		label: __('Course'),
+	},
+	{
+		key: 'progress',
+		label: __('Progress'),
+		align: 'right',
+	},
+]
 </script>
diff --git a/frontend/src/pages/Batches/components/BatchFeedback.vue b/frontend/src/pages/Batches/components/BatchFeedback.vue
index afba1c96..206cdc1c 100644
--- a/frontend/src/pages/Batches/components/BatchFeedback.vue
+++ b/frontend/src/pages/Batches/components/BatchFeedback.vue
@@ -1,7 +1,24 @@
 <template>
 	<div>
-		<div class="text-lg text-ink-gray-9 font-semibold mb-5">
-			{{ __('Feedback') }}
+		<div class="flex justify-between mb-5">
+			<div class="space-y-1">
+				<div class="text-lg text-ink-gray-9 font-semibold">
+					{{ __('Feedback') }}
+				</div>
+				<div
+					v-if="feedbackList.data?.length && isAdmin"
+					class="leading-5 text-ink-gray-7 text-sm mb-2 mt-5"
+				>
+					{{ __('Average Feedback Received') }}
+				</div>
+			</div>
+			<Button
+				v-if="feedbackList.data?.length && isAdmin"
+				variant="outline"
+				@click="showAllFeedback = true"
+			>
+				{{ __('View all feedback') }}
+			</Button>
 		</div>
 		<div v-if="user.data?.is_student">
 			<div>
@@ -43,10 +60,6 @@
 		</div>
 
 		<div v-else-if="feedbackList.data?.length">
-			<div class="leading-5 text-sm mb-2 mt-5">
-				{{ __('Average Feedback Received') }}
-			</div>
-
 			<div class="space-y-4">
 				<Rating
 					v-for="key in ratingKeys"
@@ -55,10 +68,6 @@
 					:readonly="true"
 				/>
 			</div>
-
-			<Button variant="outline" class="mt-5" @click="showAllFeedback = true">
-				{{ __('View all feedback') }}
-			</Button>
 		</div>
 		<div v-else class="text-ink-gray-7 leading-5">
 			{{ __('No feedback received yet.') }}
@@ -71,7 +80,7 @@
 	/>
 </template>
 <script setup>
-import { inject, onMounted, reactive, ref, watch } from 'vue'
+import { computed, inject, onMounted, reactive, ref, watch } from 'vue'
 import { convertToTitleCase } from '@/utils'
 import { Button, createListResource, FormControl, Rating } from 'frappe-ui'
 import FeedbackModal from '@/components/Modals/FeedbackModal.vue'
@@ -164,10 +173,15 @@ const submitFeedback = () => {
 			onSuccess: () => {
 				feedbackList.reload()
 				showFeedbackForm.value = false
+				readOnly.value = true
 			},
 		}
 	)
 }
+
+const isAdmin = computed(() => {
+	return user.data?.is_moderator || user.data?.is_evaluator
+})
 </script>
 <style>
 .feedback-list > button > div {
diff --git a/lms/lms/doctype/lms_batch/lms_batch.json b/lms/lms/doctype/lms_batch/lms_batch.json
index 3b5954f3..9e657fad 100644
--- a/lms/lms/doctype/lms_batch/lms_batch.json
+++ b/lms/lms/doctype/lms_batch/lms_batch.json
@@ -9,41 +9,43 @@
  "engine": "InnoDB",
  "field_order": [
   "section_break_earo",
+  "published",
   "title",
   "start_date",
   "end_date",
   "column_break_4",
+  "allow_self_enrollment",
   "start_time",
   "end_time",
   "timezone",
+  "section_break_wuxt",
+  "seat_count",
+  "column_break_uamg",
+  "category",
   "section_break_cssv",
-  "published",
+  "evaluation",
+  "evaluation_end_date",
   "column_break_wfkz",
-  "allow_self_enrollment",
-  "column_break_vnrp",
   "certification",
   "section_break_6",
   "description",
-  "column_break_hlqw",
   "instructors",
-  "zoom_account",
+  "column_break_hlqw",
+  "batch_details",
   "section_break_rgfj",
   "medium",
-  "category",
   "confirmation_email_template",
   "column_break_flwy",
-  "seat_count",
-  "evaluation_end_date",
+  "zoom_account",
   "notification_sent",
   "section_break_jedp",
   "video_link",
   "column_break_kpct",
   "meta_image",
-  "section_break_khcn",
-  "batch_details",
-  "batch_details_raw",
   "section_break_jgji",
   "courses",
+  "section_break_khcn",
+  "batch_details_raw",
   "assessment_tab",
   "assessment",
   "schedule_tab",
@@ -297,6 +299,7 @@
    "label": "Allow accessing future dates"
   },
   {
+   "depends_on": "evaluation",
    "fieldname": "evaluation_end_date",
    "fieldtype": "Date",
    "label": "Evaluation End Date"
@@ -341,10 +344,6 @@
    "fieldname": "column_break_wfkz",
    "fieldtype": "Column Break"
   },
-  {
-   "fieldname": "column_break_vnrp",
-   "fieldtype": "Column Break"
-  },
   {
    "default": "0",
    "fieldname": "certification",
@@ -358,7 +357,8 @@
   },
   {
    "fieldname": "section_break_cssv",
-   "fieldtype": "Section Break"
+   "fieldtype": "Section Break",
+   "label": "Certification"
   },
   {
    "fieldname": "zoom_account",
@@ -385,6 +385,20 @@
   {
    "fieldname": "column_break_kpct",
    "fieldtype": "Column Break"
+  },
+  {
+   "default": "0",
+   "fieldname": "evaluation",
+   "fieldtype": "Check",
+   "label": "Evaluation"
+  },
+  {
+   "fieldname": "section_break_wuxt",
+   "fieldtype": "Section Break"
+  },
+  {
+   "fieldname": "column_break_uamg",
+   "fieldtype": "Column Break"
   }
  ],
  "grid_page_length": 50,
@@ -407,7 +421,7 @@
    "link_fieldname": "payment_for_document"
   }
  ],
- "modified": "2026-01-13 18:50:27.420712",
+ "modified": "2026-02-13 14:23:51.913875",
  "modified_by": "sayali@frappe.io",
  "module": "LMS",
  "name": "LMS Batch",
diff --git a/lms/lms/utils.py b/lms/lms/utils.py
index f9c75bf9..f61b58c5 100644
--- a/lms/lms/utils.py
+++ b/lms/lms/utils.py
@@ -1128,6 +1128,7 @@ def get_batch_details(batch: str):
 			"evaluation_end_date",
 			"allow_self_enrollment",
 			"certification",
+			"evaluation",
 			"timezone",
 			"category",
 			"zoom_account",
@@ -1148,6 +1149,10 @@ def get_batch_details(batch: str):
 	batch_details.courses = frappe.get_all(
 		"Batch Course", filters={"parent": batch}, fields=["course", "title", "evaluator"]
 	)
+	batch_details.assessments = frappe.get_all(
+		"LMS Assessment", {"parent": batch}, ["assessment_name", "assessment_type"]
+	)
+
 	if can_modify_batch(batch):
 		batch_details.students = batch_students
 	elif is_student_enrolled:
@@ -1346,14 +1351,6 @@ def get_exercise_details(assessment: dict, member: str) -> dict:
 		assessment.edit_url = f"/exercises/{assessment.assessment_name}/submission/new"
 
 
-@frappe.whitelist()
-def get_batch_assessment_count(batch: str) -> int:
-	frappe.only_for(["Moderator", "Batch Evaluator"])
-	if not frappe.db.exists("LMS Batch", batch):
-		frappe.throw(_("The specified batch does not exist."))
-	return frappe.db.count("LMS Assessment", {"parent": batch})
-
-
 @frappe.whitelist()
 def get_batch_students(
 	filters: dict, offset: int = 0, limit_start: int = 0, limit_page_length: int = None, limit: int = None
@@ -1669,8 +1666,10 @@ def create_discussion_topic(doctype: str, docname: str) -> str:
 
 @frappe.whitelist()
 def get_discussion_replies(topic: str):
-	doctype = frappe.db.get_value("Discussion Topic", topic, "reference_doctype")
-	if not can_access_topic(doctype, topic):
+	topic_details = frappe.db.get_value(
+		"Discussion Topic", topic, ["reference_doctype", "reference_docname"], as_dict=True
+	)
+	if not can_access_topic(topic_details.reference_doctype, topic_details.reference_docname):
 		frappe.throw(_("You are not authorized to view the discussion replies for this topic."))
 
 	replies = frappe.get_all(