From 66486a5a1c7d76c9f99c0c54eff22ff85abfa780 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 19 Jan 2026 18:17:40 +0530 Subject: [PATCH] fix: do no execute send_notification bg job from batch immediately --- lms/lms/doctype/lms_batch/lms_batch.js | 8 -------- lms/lms/doctype/lms_batch/lms_batch.py | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/lms/lms/doctype/lms_batch/lms_batch.js b/lms/lms/doctype/lms_batch/lms_batch.js index f196c867..d18d1430 100644 --- a/lms/lms/doctype/lms_batch/lms_batch.js +++ b/lms/lms/doctype/lms_batch/lms_batch.js @@ -3,14 +3,6 @@ frappe.ui.form.on("LMS Batch", { onload: function (frm) { - frm.set_query("student", "students", function (doc) { - return { - filters: { - ignore_user_type: 1, - }, - }; - }); - frm.set_query("reference_doctype", "timetable", function () { let doctypes = ["Course Lesson", "LMS Quiz", "LMS Assignment"]; return { diff --git a/lms/lms/doctype/lms_batch/lms_batch.py b/lms/lms/doctype/lms_batch/lms_batch.py index 19208402..35d44a2e 100644 --- a/lms/lms/doctype/lms_batch/lms_batch.py +++ b/lms/lms/doctype/lms_batch/lms_batch.py @@ -37,7 +37,7 @@ class LMSBatch(Document): def on_update(self): if self.has_value_changed("published") and self.published: - frappe.enqueue(send_notification_for_published_batch, batch=self, now=True) + frappe.enqueue(send_notification_for_published_batch, batch=self) def autoname(self): if not self.name: