MIDNIGHT/enlight-lms
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Add missing /lms prefix to assignment submission notification links

Browse Source 
Fixes #1969

- Added /lms prefix to notification link in lms_assignment_submission.py
- Added /lms prefix to assessment URL in utils.py
- Ensures consistent routing with other notification links (courses, billing, etc.)
- Resolves 404 errors when users click 'View' on assignment submission notifications
This commit is contained in:
Om vataliya
2026-01-09 23:45:29 +05:30
parent e1d343528d
commit 7dccef6b10
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py
View File

@@ -73,13 +73,7 @@ class LMSAssignmentSubmission(Document):
"for_user": self.owner, "for_user": self.owner,
"from_user": self.evaluator, "from_user": self.evaluator,
"type": "Alert", "type": "Alert",
"link": f"/assignment-submission/{self.assignment}/{self.name}", "link": f"/lms/assignment-submission/{self.assignment}/{self.name}",
}
)
make_notification_logs(notification, [self.member])
@frappe.whitelist()
def upload_assignment( def upload_assignment(
assignment_attachment=None, assignment_attachment=None,
answer=None, answer=None,

2
lms/lms/utils.py
View File

@@ -1269,7 +1269,7 @@ def get_assignment_details(assessment, member):
assessment.edit_url = f"/assignments/{assessment.assessment_name}" assessment.edit_url = f"/assignments/{assessment.assessment_name}"
submission_name = existing_submission if existing_submission else "new-submission" submission_name = existing_submission if existing_submission else "new-submission"
assessment.url = f"/assignment-submission/{assessment.assessment_name}/{submission_name}" assessment.url = f"/lms/assignment-submission/{assessment.assessment_name}/{submission_name}"
return assessment return assessment