diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a0b8f7a4..bfe2b8b4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,6 +8,7 @@ on: pull_request: {} jobs: tests: + name: Server Tests runs-on: ubuntu-latest strategy: fail-fast: false diff --git a/cypress/e2e/batch_creation.cy.js b/cypress/e2e/batch_creation.cy.js index 0517c8ac..f0fe6ed1 100644 --- a/cypress/e2e/batch_creation.cy.js +++ b/cypress/e2e/batch_creation.cy.js @@ -158,7 +158,7 @@ describe("Batch Creation", () => { cy.get('div[role="dialog"]') .first() .find("div[label='Student']") - .find("button") + .find("div") .first() .click(); cy.get("input[placeholder='Search']").type(randomEmail); diff --git a/cypress/e2e/course_creation.cy.js b/cypress/e2e/course_creation.cy.js index de0113fe..b5f5ae73 100644 --- a/cypress/e2e/course_creation.cy.js +++ b/cypress/e2e/course_creation.cy.js @@ -53,7 +53,7 @@ describe("Course Creation", () => { }); }); - cy.button("Create").last().click(); + cy.button("Save").last().click(); // Edit Course Details cy.wait(500); @@ -65,12 +65,9 @@ describe("Course Creation", () => { .contains("Category") .parent() .within(() => { - cy.get("input").click(); + cy.get("button").click(); }); - cy.get("[id^=headlessui-combobox-option-") - .should("be.visible") - .first() - .click(); + cy.get("div").contains("Business").click(); cy.get("label").contains("Published").click(); cy.get("label").contains("Published On").type("2021-01-01"); diff --git a/frontend/src/components/Modals/FeedbackModal.vue b/frontend/src/components/Modals/FeedbackModal.vue index c7318e48..b69d6615 100644 --- a/frontend/src/components/Modals/FeedbackModal.vue +++ b/frontend/src/components/Modals/FeedbackModal.vue @@ -7,7 +7,7 @@ > - diff --git a/frontend/src/pages/Batches/components/BatchOverlay.vue b/frontend/src/pages/Batches/components/BatchOverlay.vue index be2907e3..d7b88e00 100644 --- a/frontend/src/pages/Batches/components/BatchOverlay.vue +++ b/frontend/src/pages/Batches/components/BatchOverlay.vue @@ -137,7 +137,7 @@ const enroll = createResource({ const enrollInBatch = () => { if (!user.data) { - window.location.href = `/login?redirect-to=/batches/details/${props.batch.data.name}` + window.location.href = `/login?redirect-to=/batches/${props.batch.data.name}` } enroll.submit( {}, diff --git a/frontend/src/pages/Batches/components/BatchStudentProgress.vue b/frontend/src/pages/Batches/components/BatchStudentProgress.vue index 56d57ccc..fb5a3d6a 100644 --- a/frontend/src/pages/Batches/components/BatchStudentProgress.vue +++ b/frontend/src/pages/Batches/components/BatchStudentProgress.vue @@ -36,7 +36,7 @@ :columns="assessmentColumns" :rows="studentDetails.data.assessments" row-key="title" - class="border rounded-lg" + class="border border-outline-gray-modals rounded-lg" :options="{ selectable: false, showTooltip: false, @@ -78,7 +78,7 @@ :columns="courseColumns" :rows="studentDetails.data.courses" row-key="title" - class="border rounded-lg" + class="border border-outline-gray-modals rounded-lg" :options="{ selectable: false, showTooltip: false, diff --git a/frontend/src/pages/Batches/components/BatchStudents.vue b/frontend/src/pages/Batches/components/BatchStudents.vue deleted file mode 100644 index 7d3e0bc9..00000000 --- a/frontend/src/pages/Batches/components/BatchStudents.vue +++ /dev/null @@ -1,226 +0,0 @@ - - diff --git a/frontend/src/pages/Home/StudentHome.vue b/frontend/src/pages/Home/StudentHome.vue index 10e9f1f4..1183c307 100644 --- a/frontend/src/pages/Home/StudentHome.vue +++ b/frontend/src/pages/Home/StudentHome.vue @@ -72,7 +72,7 @@ -
+
{{ diff --git a/frontend/src/router.js b/frontend/src/router.js index 1d57a76f..35e722b4 100644 --- a/frontend/src/router.js +++ b/frontend/src/router.js @@ -44,6 +44,10 @@ const routes = [ name: 'Batches', component: () => import('@/pages/Batches/Batches.vue'), }, + { + path: '/batches/details/:batchName', + redirect: (to) => `/batches/${to.params.batchName}`, + }, { path: '/batches/:batchName', name: 'BatchDetail', diff --git a/lms/lms/doctype/lms_batch/lms_batch.js b/lms/lms/doctype/lms_batch/lms_batch.js index d6fa873e..186c7c85 100644 --- a/lms/lms/doctype/lms_batch/lms_batch.js +++ b/lms/lms/doctype/lms_batch/lms_batch.js @@ -50,7 +50,7 @@ frappe.ui.form.on("LMS Batch", { refresh: (frm) => { const lmsPath = frappe.boot.lms_path || "lms"; frm.add_web_link( - `/${lmsPath}/batches/details/${frm.doc.name}`, + `/${lmsPath}/batches/${frm.doc.name}`, "See on website" ); }, diff --git a/lms/lms/doctype/lms_batch/lms_batch.py b/lms/lms/doctype/lms_batch/lms_batch.py index 4da344da..70c79216 100644 --- a/lms/lms/doctype/lms_batch/lms_batch.py +++ b/lms/lms/doctype/lms_batch/lms_batch.py @@ -165,7 +165,7 @@ def send_email_notification_for_published_batch(batch): "medium": batch.medium, "timezone": batch.timezone, "instructors": instructors, - "batch_url": frappe.utils.get_url(get_lms_route(f"batches/details/{batch.name}")), + "batch_url": frappe.utils.get_url(get_lms_route(f"batches/{batch.name}")), } frappe.sendmail( @@ -194,7 +194,7 @@ def send_system_notification_for_published_batch(batch): "document_name": batch.name, "from_user": instructors[0] if instructors else None, "type": "Alert", - "link": get_lms_route(f"batches/details/{batch.name}"), + "link": get_lms_route(f"batches/{batch.name}"), } ) make_notification_logs(notification, students)