From 8d41a3d688ab46340565d8e20431f76691021bea Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Mon, 15 Dec 2025 14:51:37 +0530
Subject: [PATCH] test: certificate and rating test

---
 frontend/components.d.ts                  |  5 ----
 frontend/src/components/CourseCard.vue    | 10 --------
 frontend/src/components/CourseOutline.vue |  8 +++----
 lms/desktop_icon/frappe_lms.json          | 19 +++++++++++++++
 lms/lms/test_utils.py                     | 29 +++++++++++++++++++++++
 lms/lms/utils.py                          |  1 +
 6 files changed, 53 insertions(+), 19 deletions(-)
 create mode 100644 lms/desktop_icon/frappe_lms.json

diff --git a/frontend/components.d.ts b/frontend/components.d.ts
index 95951283..2b0e68e0 100644
--- a/frontend/components.d.ts
+++ b/frontend/components.d.ts
@@ -87,11 +87,6 @@ declare module 'vue' {
     LiveClassAttendance: typeof import('./src/components/Modals/LiveClassAttendance.vue')['default']
     LiveClassModal: typeof import('./src/components/Modals/LiveClassModal.vue')['default']
     LMSLogo: typeof import('./src/components/Icons/LMSLogo.vue')['default']
-    LucideArrowDown: typeof import('~icons/lucide/arrow-down')['default']
-    LucideArrowUp: typeof import('~icons/lucide/arrow-up')['default']
-    LucideCornerDownLeft: typeof import('~icons/lucide/corner-down-left')['default']
-    LucideSearch: typeof import('~icons/lucide/search')['default']
-    LucideX: typeof import('~icons/lucide/x')['default']
     Members: typeof import('./src/components/Settings/Members.vue')['default']
     MobileLayout: typeof import('./src/components/MobileLayout.vue')['default']
     MultiSelect: typeof import('./src/components/Controls/MultiSelect.vue')['default']
diff --git a/frontend/src/components/CourseCard.vue b/frontend/src/components/CourseCard.vue
index 1d49ffb3..d0e308cf 100644
--- a/frontend/src/components/CourseCard.vue
+++ b/frontend/src/components/CourseCard.vue
@@ -157,16 +157,6 @@ const getGradientColor = () => {
 	let color = props.course.card_gradient?.toLowerCase() || 'blue'
 	let colorMap = colors[theme][color]
 	return `linear-gradient(to top right, black, ${colorMap[200]})`
-	/* return `bg-gradient-to-br from-${color}-100 via-${color}-200 to-${color}-400` */
-	/* return `linear-gradient(to bottom right, ${colorMap[100]}, ${colorMap[400]})` */
-	/* return `radial-gradient(ellipse at 80% 20%, black 20%, ${colorMap[500]} 100%)` */
-	/* return `radial-gradient(ellipse at 30% 70%, black 50%, ${colorMap[500]} 100%)` */
-	/* return `radial-gradient(ellipse at 80% 20%, ${colorMap[100]} 0%, ${colorMap[300]} 50%, ${colorMap[500]} 100%)` */
-	/* return `conic-gradient(from 180deg at 50% 50%, ${colorMap[100]} 0%, ${colorMap[200]} 50%, ${colorMap[400]} 100%)` */
-	/* return `linear-gradient(135deg, ${colorMap[100]}, ${colorMap[300]}), linear-gradient(120deg, rgba(255,255,255,0.4) 0%, transparent 60%) ` */
-	/* return `radial-gradient(circle at 20% 30%, ${colorMap[100]} 0%, transparent 40%),
-		radial-gradient(circle at 80% 40%, ${colorMap[200]} 0%, transparent 50%),
-		linear-gradient(135deg, ${colorMap[300]} 0%, ${colorMap[400]} 100%);` */
 }
 </script>
 <style>
diff --git a/frontend/src/components/CourseOutline.vue b/frontend/src/components/CourseOutline.vue
index a68b20a6..30df3aa5 100644
--- a/frontend/src/components/CourseOutline.vue
+++ b/frontend/src/components/CourseOutline.vue
@@ -95,8 +95,8 @@
 													name: allowEdit ? 'LessonForm' : 'Lesson',
 													params: {
 														courseName: courseName,
-														chapterNumber: lesson.number.split('.')[0],
-														lessonNumber: lesson.number.split('.')[1],
+														chapterNumber: lesson.number.split('-')[0],
+														lessonNumber: lesson.number.split('-')[1],
 													},
 												}"
 											>
@@ -389,8 +389,8 @@ const redirectToChapter = (chapter) => {
 
 const isActiveLesson = (lessonNumber) => {
 	return (
-		route.params.chapterNumber == lessonNumber.split('.')[0] &&
-		route.params.lessonNumber == lessonNumber.split('.')[1]
+		route.params.chapterNumber == lessonNumber.split('-')[0] &&
+		route.params.lessonNumber == lessonNumber.split('-')[1]
 	)
 }
 </script>
diff --git a/lms/desktop_icon/frappe_lms.json b/lms/desktop_icon/frappe_lms.json
new file mode 100644
index 00000000..f137321c
--- /dev/null
+++ b/lms/desktop_icon/frappe_lms.json
@@ -0,0 +1,19 @@
+{
+ "app": "lms",
+ "creation": "2025-12-15 14:31:50.704854",
+ "docstatus": 0,
+ "doctype": "Desktop Icon",
+ "hidden": 0,
+ "icon_type": "App",
+ "idx": 0,
+ "label": "Frappe LMS",
+ "link": "/lms",
+ "link_type": "External",
+ "logo_url": "/assets/lms/frontend/learning.svg",
+ "modified": "2025-12-15 14:31:50.704854",
+ "modified_by": "Administrator",
+ "name": "Frappe LMS",
+ "owner": "Administrator",
+ "roles": [],
+ "standard": 1
+}
diff --git a/lms/lms/test_utils.py b/lms/lms/test_utils.py
index 35e00d47..399c64f5 100644
--- a/lms/lms/test_utils.py
+++ b/lms/lms/test_utils.py
@@ -2,6 +2,8 @@ import unittest
 
 import frappe
 
+from lms.lms.doctype.lms_certificate.lms_certificate import get_default_certificate_template, is_certified
+
 from .utils import (
 	get_average_rating,
 	get_chapters,
@@ -39,6 +41,8 @@ class TestUtils(unittest.TestCase):
 		self.add_rating(self.course.name, self.student1.email, 0.8, "Good course")
 		self.add_rating(self.course.name, self.student2.email, 1, "Excellent course")
 
+		self.create_certificate(self.course.name, self.student1.email)
+
 	def create_a_course(self):
 		course = frappe.new_doc("LMS Course")
 		course.title = "Utility Course"
@@ -97,6 +101,15 @@ class TestUtils(unittest.TestCase):
 		else:
 			return frappe.get_doc("User", email)
 
+	def create_certificate(self, course_name, member):
+		certificate = frappe.new_doc("LMS Certificate")
+		certificate.course = course_name
+		certificate.member = member
+		certificate.issue_date = frappe.utils.nowdate()
+		certificate.template = get_default_certificate_template()
+		certificate.save()
+		return certificate
+
 	def test_simple_slugs(self):
 		self.assertEqual(slugify("hello-world"), "hello-world")
 		self.assertEqual(slugify("Hello World"), "hello-world")
@@ -205,12 +218,28 @@ class TestUtils(unittest.TestCase):
 		self.assertIsNotNone(has_student_role("student1@example.com"))
 		self.assertIsNotNone(has_student_role("student2@example.com"))
 
+	def test_is_certified(self):
+		frappe.session.user = self.student1.email
+		self.assertIsNotNone(is_certified(self.course.name))
+		frappe.session.user = self.student2.email
+		self.assertIsNone(is_certified(self.course.name))
+		frappe.session.user = "Administrator"
+
+	def test_rating_validation(self):
+		student3 = self.create_user("student3@example.com", "Emily", "Cooper", ["LMS Student"])
+		with self.assertRaises(frappe.exceptions.ValidationError):
+			self.add_rating(self.course.name, student3.email, -0.5, "Bad course")
+		frappe.session.user = "Administrator"
+		frappe.delete_doc("User", student3.email)
+
 	def tearDown(self):
 		if frappe.db.exists("LMS Course", self.course.name):
+			frappe.db.delete("LMS Certificate", {"course": self.course.name})
 			frappe.db.delete("LMS Enrollment", {"course": self.course.name})
 			frappe.db.delete("LMS Course Review", {"course": self.course.name})
 			frappe.db.delete("Course Lesson", {"course": self.course.name})
 			frappe.db.delete("Course Chapter", {"course": self.course.name})
+			frappe.db.delete("Course Instructor", {"parent": self.course.name})
 			frappe.delete_doc("LMS Course", self.course.name)
 
 		frappe.delete_doc("User", "student1@example.com")
diff --git a/lms/lms/utils.py b/lms/lms/utils.py
index e17b38da..055336ad 100644
--- a/lms/lms/utils.py
+++ b/lms/lms/utils.py
@@ -822,6 +822,7 @@ def get_course_fields():
 		"title",
 		"tags",
 		"image",
+		"video_link",
 		"card_gradient",
 		"short_introduction",
 		"published",