From 8f6810923da6760c7743806d54f95e2a6e9d25d9 Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Mon, 9 Feb 2026 14:42:32 +0530
Subject: [PATCH] fix: only published courses should be added to batch

---
 frontend/src/components/Modals/BatchCourseModal.vue | 3 ++-
 lms/lms/api.py                                      | 2 +-
 lms/lms/doctype/lms_batch/lms_batch.js              | 8 ++++++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Modals/BatchCourseModal.vue b/frontend/src/components/Modals/BatchCourseModal.vue
index 8b67c0e1..a5768442 100644
--- a/frontend/src/components/Modals/BatchCourseModal.vue
+++ b/frontend/src/components/Modals/BatchCourseModal.vue
@@ -2,7 +2,7 @@
 	<Dialog
 		v-model="show"
 		:options="{
-			title: __('Add a course'),
+			title: __('Add Course'),
 			size: 'sm',
 			actions: [
 				{
@@ -19,6 +19,7 @@
 				v-model="course"
 				:label="__('Course')"
 				:required="true"
+				:filters="{ published: 1 }"
 				:onCreate="
 					(value, close) => {
 						close()
diff --git a/lms/lms/api.py b/lms/lms/api.py
index 574ccd29..aab6ee9c 100644
--- a/lms/lms/api.py
+++ b/lms/lms/api.py
@@ -183,7 +183,7 @@ def get_job_details(job):
 
 
 @frappe.whitelist(allow_guest=True)
-def get_job_opportunities(filters=None, orFilters=None):
+def get_job_opportunities(filters: dict = None, orFilters: dict = None):
 	if not filters:
 		filters = {}
 
diff --git a/lms/lms/doctype/lms_batch/lms_batch.js b/lms/lms/doctype/lms_batch/lms_batch.js
index dbed92c9..d6fa873e 100644
--- a/lms/lms/doctype/lms_batch/lms_batch.js
+++ b/lms/lms/doctype/lms_batch/lms_batch.js
@@ -12,6 +12,14 @@ frappe.ui.form.on("LMS Batch", {
 			};
 		});
 
+		frm.set_query("course", "courses", function () {
+			return {
+				filters: {
+					published: 1,
+				},
+			};
+		});
+
 		frm.set_query("assessment_type", "assessment", function () {
 			let doctypes = ["LMS Quiz", "LMS Assignment"];
 			return {