From 8fe9bad2bb83947348861bddf924ff75cfb6cb4c Mon Sep 17 00:00:00 2001 From: Anand Chitipothu Date: Tue, 12 Oct 2021 12:38:26 +0530 Subject: [PATCH] fix: error on reindex-exercises Issue fossunited/mon_school#69 --- community/lms/doctype/lms_course/lms_course.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/community/lms/doctype/lms_course/lms_course.py b/community/lms/doctype/lms_course/lms_course.py index 5a60f38c..feebe8f3 100644 --- a/community/lms/doctype/lms_course/lms_course.py +++ b/community/lms/doctype/lms_course/lms_course.py @@ -225,17 +225,14 @@ class LMSCourse(Document): def reindex_exercises(self): for i, c in enumerate(self.get_chapters(), start=1): - if c.index_ != i: - c.index_ = i - c.save() - self._reindex_exercises_in_chapter(c) + self._reindex_exercises_in_chapter(c, i) - def _reindex_exercises_in_chapter(self, c): + def _reindex_exercises_in_chapter(self, c, index): i = 1 for lesson in self.get_lessons(c): for exercise in lesson.get_exercises(): exercise.index_ = i - exercise.index_label = f"{c.index_}.{i}" + exercise.index_label = f"{index}.{i}" exercise.save() i += 1