From 982ac98e271ba38d6548db4e96654a6152d20ba7 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 27 Oct 2025 10:32:24 +0530 Subject: [PATCH 1/3] fix: resolved the issue that appeared when adding a chapter --- lms/lms/doctype/course_chapter/course_chapter.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lms/lms/doctype/course_chapter/course_chapter.py b/lms/lms/doctype/course_chapter/course_chapter.py index 2c776c79..2fe3e615 100644 --- a/lms/lms/doctype/course_chapter/course_chapter.py +++ b/lms/lms/doctype/course_chapter/course_chapter.py @@ -4,16 +4,16 @@ import frappe from frappe.model.document import Document -from lms.lms.api import update_course_statistics -from lms.lms.utils import get_course_progress +from lms.lms.utils import get_course_progress, get_lesson_count class CourseChapter(Document): def on_update(self): self.recalculate_course_progress() - update_course_statistics() + self.update_lesson_count() def recalculate_course_progress(self): + """Recalculate course progress if a new lesson is added or removed""" previous_lessons = self.get_doc_before_save() and self.get_doc_before_save().as_dict().lessons current_lessons = self.lessons @@ -22,3 +22,7 @@ class CourseChapter(Document): for enrollment in enrolled_members: new_progress = get_course_progress(self.course, enrollment.member) frappe.db.set_value("LMS Enrollment", enrollment.name, "progress", new_progress) + + def update_lesson_count(self): + """Update lesson count in the course""" + frappe.db.set_value("LMS Course", self.course, "lessons", get_lesson_count(self.course)) From 8749e21744547ae32f729bde05c854113e126750 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 27 Oct 2025 11:06:09 +0530 Subject: [PATCH 2/3] fix: only users with moderator and instructor role should have access to quiz form --- frontend/src/components/Modals/Question.vue | 3 +- frontend/src/pages/CourseForm.vue | 1 - frontend/src/pages/LessonForm.vue | 1 - frontend/src/pages/QuizForm.vue | 6 +- frontend/yarn.lock | 988 ++++++------ .../doctype/course_chapter/course_chapter.py | 1 + yarn.lock | 1374 ----------------- 7 files changed, 498 insertions(+), 1876 deletions(-) delete mode 100644 yarn.lock diff --git a/frontend/src/components/Modals/Question.vue b/frontend/src/components/Modals/Question.vue index bfaf3239..221ac0ee 100644 --- a/frontend/src/components/Modals/Question.vue +++ b/frontend/src/components/Modals/Question.vue @@ -126,7 +126,7 @@ import { Button, toast, } from 'frappe-ui' -import { computed, watch, reactive, ref, inject } from 'vue' +import { watch, reactive, ref, inject } from 'vue' import Link from '@/components/Controls/Link.vue' import { useOnboarding } from 'frappe-ui/frappe' @@ -141,6 +141,7 @@ const existingQuestion = reactive({ question: '', marks: 1, }) + const question = reactive({ question: '', type: 'Choices', diff --git a/frontend/src/pages/CourseForm.vue b/frontend/src/pages/CourseForm.vue index 843d8f40..9c689983 100644 --- a/frontend/src/pages/CourseForm.vue +++ b/frontend/src/pages/CourseForm.vue @@ -329,7 +329,6 @@