From a3e7d1f981eefc86980e650914732692efca94aa Mon Sep 17 00:00:00 2001 From: Fahid Latheef Alungal Date: Tue, 2 Sep 2025 02:29:19 +0530 Subject: [PATCH] refactor: derive is_scorm_package from Lesson instead of Chapter --- lms/lms/utils.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lms/lms/utils.py b/lms/lms/utils.py index 5adde244..98a6ab72 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1222,24 +1222,23 @@ def get_course_outline(course, progress=False): @frappe.whitelist(allow_guest=True) def get_lesson(course, chapter, lesson): chapter_name = frappe.db.get_value("Chapter Reference", {"parent": course, "idx": chapter}, "chapter") - is_scorm_chapter = frappe.db.get_value("Course Chapter", chapter_name, "is_scorm_package") lesson_name = frappe.db.get_value("Lesson Reference", {"parent": chapter_name, "idx": lesson}, "lesson") lesson_details = frappe.db.get_value( "Course Lesson", lesson_name, - ["include_in_preview", "title"], + ["include_in_preview", "title", "is_scorm_package"], as_dict=1, ) - if is_scorm_chapter: + if not lesson_details: + return {} + + if lesson_details.is_scorm_package: return { "is_scorm_package": True, "chapter_name": chapter_name, } - if not lesson_details: - return {} - membership = get_membership(course) course_info = frappe.db.get_value( "LMS Course",