From b274900ae0112c7df70033b1e5004bceda228efb Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 11 Aug 2025 19:34:22 +0530 Subject: [PATCH] chore: removed profile page renderers --- lms/hooks.py | 4 ---- lms/lms/doctype/course_evaluator/course_evaluator.py | 2 +- lms/lms/widgets/Avatar.html | 2 +- lms/lms/widgets/CourseCard.html | 2 +- lms/patches/v0_0/change_course_creation_settings.py | 2 +- lms/templates/reviews.html | 2 +- 6 files changed, 5 insertions(+), 9 deletions(-) diff --git a/lms/hooks.py b/lms/hooks.py index 337db658..a0a6a864 100644 --- a/lms/hooks.py +++ b/lms/hooks.py @@ -194,7 +194,6 @@ jinja = { "lms.lms.utils.get_instructors", "lms.lms.utils.get_lesson_index", "lms.lms.utils.get_lesson_url", - "lms.page_renderers.get_profile_url", "lms.lms.utils.is_instructor", "lms.lms.utils.get_palette", ], @@ -230,10 +229,7 @@ lms_markdown_macro_renderers = { "PDF": "lms.plugins.pdf_renderer", } -# page_renderer to manage profile pages page_renderer = [ - "lms.page_renderers.ProfileRedirectPage", - "lms.page_renderers.ProfilePage", "lms.page_renderers.SCORMRenderer", ] diff --git a/lms/lms/doctype/course_evaluator/course_evaluator.py b/lms/lms/doctype/course_evaluator/course_evaluator.py index f1a52255..80ac7de9 100644 --- a/lms/lms/doctype/course_evaluator/course_evaluator.py +++ b/lms/lms/doctype/course_evaluator/course_evaluator.py @@ -79,7 +79,7 @@ def get_schedule(course, date, batch=None): ) for slot in booked_slots: - same_slot = list(filter(lambda x: x.start_time == slot.start_time and x.day == slot.day, all_slots)) + same_slot = [x for x in all_slots if x.start_time == slot.start_time and x.day == slot.day] if len(same_slot): all_slots.remove(same_slot[0]) diff --git a/lms/lms/widgets/Avatar.html b/lms/lms/widgets/Avatar.html index 063b2c79..ab21f7ba 100644 --- a/lms/lms/widgets/Avatar.html +++ b/lms/lms/widgets/Avatar.html @@ -1,6 +1,6 @@ {% set color = get_palette(member.full_name) %} - + {% if member.user_image %} diff --git a/lms/lms/widgets/CourseCard.html b/lms/lms/widgets/CourseCard.html index 62940b7d..de74f2c0 100644 --- a/lms/lms/widgets/CourseCard.html +++ b/lms/lms/widgets/CourseCard.html @@ -93,7 +93,7 @@ {% endif %} {% endfor %} - + {% if ins_len == 1 %} {{ instructors[0].full_name }} diff --git a/lms/patches/v0_0/change_course_creation_settings.py b/lms/patches/v0_0/change_course_creation_settings.py index 7432846c..22bc4fc4 100644 --- a/lms/patches/v0_0/change_course_creation_settings.py +++ b/lms/patches/v0_0/change_course_creation_settings.py @@ -4,4 +4,4 @@ import frappe def execute(): value = frappe.db.get_single_value("LMS Settings", "portal_course_creation") if value == "Course Instructor Role": - frappe.db.set_value("LMS Settings", None, "portal_course_creation", "Course Creator Role") + frappe.db.set_single_value("LMS Settings", "portal_course_creation", "Course Creator Role") diff --git a/lms/templates/reviews.html b/lms/templates/reviews.html index a1063aba..e6c1a6be 100644 --- a/lms/templates/reviews.html +++ b/lms/templates/reviews.html @@ -65,7 +65,7 @@