From a5e948bba8bb427b58460b5a83679cca4f7492eb Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Wed, 25 Feb 2026 12:37:09 +0530 Subject: [PATCH 1/7] fix: permission issue during quiz submission (cherry picked from commit af5bce9e34df945cdc368eceb2a1c3e56023fb34) # Conflicts: # lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json --- .../lms_quiz_submission/lms_quiz_submission.json | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json index b2c525d1..e3a8cb5f 100644 --- a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json +++ b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json @@ -116,8 +116,13 @@ "in_create": 1, "index_web_pages_for_search": 1, "links": [], +<<<<<<< HEAD "modified": "2024-10-07 16:52:04.162521", "modified_by": "Administrator", +======= + "modified": "2026-02-25 12:36:40.110346", + "modified_by": "sayali@frappe.io", +>>>>>>> af5bce9e (fix: permission issue during quiz submission) "module": "LMS", "name": "LMS Quiz Submission", "owner": "Administrator", @@ -138,11 +143,20 @@ "create": 1, "email": 1, "export": 1, +<<<<<<< HEAD +======= + "if_owner": 1, +>>>>>>> af5bce9e (fix: permission issue during quiz submission) "print": 1, "read": 1, "report": 1, "role": "LMS Student", +<<<<<<< HEAD "share": 1 +======= + "share": 1, + "write": 1 +>>>>>>> af5bce9e (fix: permission issue during quiz submission) } ], "sort_field": "modified", From 3a1a7db3869dded4b775c272ded89477d5464b26 Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Wed, 25 Feb 2026 13:06:37 +0530 Subject: [PATCH 2/7] chore: resolved conflicts --- .../lms_quiz_submission.json | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json index e3a8cb5f..b358a254 100644 --- a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json +++ b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json @@ -116,13 +116,8 @@ "in_create": 1, "index_web_pages_for_search": 1, "links": [], -<<<<<<< HEAD - "modified": "2024-10-07 16:52:04.162521", - "modified_by": "Administrator", -======= "modified": "2026-02-25 12:36:40.110346", - "modified_by": "sayali@frappe.io", ->>>>>>> af5bce9e (fix: permission issue during quiz submission) + "modified_by": "Administrator", "module": "LMS", "name": "LMS Quiz Submission", "owner": "Administrator", @@ -143,20 +138,13 @@ "create": 1, "email": 1, "export": 1, -<<<<<<< HEAD -======= "if_owner": 1, ->>>>>>> af5bce9e (fix: permission issue during quiz submission) "print": 1, "read": 1, "report": 1, "role": "LMS Student", -<<<<<<< HEAD - "share": 1 -======= "share": 1, - "write": 1 ->>>>>>> af5bce9e (fix: permission issue during quiz submission) + "write": 1f } ], "sort_field": "modified", @@ -164,4 +152,4 @@ "states": [], "title_field": "member_name", "track_changes": 1 -} \ No newline at end of file +} From 593c70affb248e36ad9c878014c5d4064b076576 Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Wed, 25 Feb 2026 13:07:05 +0530 Subject: [PATCH 3/7] chore: resolved conflicts --- lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json index b358a254..fd0a127c 100644 --- a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json +++ b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json @@ -144,7 +144,7 @@ "report": 1, "role": "LMS Student", "share": 1, - "write": 1f + "write": 1, } ], "sort_field": "modified", From e7ce850691563373d7513c418cc2336cdebd4328 Mon Sep 17 00:00:00 2001 From: Jannat Patel <31363128+pateljannat@users.noreply.github.com> Date: Wed, 25 Feb 2026 16:45:02 +0530 Subject: [PATCH 4/7] fix: removed trailing comma at the end of permission --- lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json index fd0a127c..1fd049ac 100644 --- a/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json +++ b/lms/lms/doctype/lms_quiz_submission/lms_quiz_submission.json @@ -144,7 +144,7 @@ "report": 1, "role": "LMS Student", "share": 1, - "write": 1, + "write": 1 } ], "sort_field": "modified", From 315ec3d65505b0ddacbbed6bae2faeda83c13a95 Mon Sep 17 00:00:00 2001 From: Frappe PR Bot Date: Wed, 25 Feb 2026 12:36:10 +0000 Subject: [PATCH 5/7] chore(release): Bumped to Version 2.45.1 --- lms/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/__init__.py b/lms/__init__.py index a6a5b127..99ca0c3d 100644 --- a/lms/__init__.py +++ b/lms/__init__.py @@ -1 +1 @@ -__version__ = "2.44.0" +__version__ = "2.45.1" From 4771ebbcfd602a95040def89922b391b0f11ac4d Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Tue, 3 Mar 2026 12:48:51 +0530 Subject: [PATCH 6/7] fix: enrollment error during course progress --- lms/lms/doctype/lms_enrollment/lms_enrollment.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lms/lms/doctype/lms_enrollment/lms_enrollment.py b/lms/lms/doctype/lms_enrollment/lms_enrollment.py index e2d39429..e4ecfa6d 100644 --- a/lms/lms/doctype/lms_enrollment/lms_enrollment.py +++ b/lms/lms/doctype/lms_enrollment/lms_enrollment.py @@ -8,7 +8,7 @@ from frappe.utils import ceil class LMSEnrollment(Document): - def validate(self): + def before_insert(self): self.validate_duplicate_enrollment() self.validate_course_enrollment_eligibility() self.validate_owner() @@ -27,6 +27,7 @@ class LMSEnrollment(Document): { "course": self.course, "member": self.member, + "name": ["!=", self.name], }, ) From 2c2e8ca11266ca8cb89795110c0da9ae84215364 Mon Sep 17 00:00:00 2001 From: Frappe PR Bot Date: Tue, 3 Mar 2026 07:19:36 +0000 Subject: [PATCH 7/7] chore(release): Bumped to Version 2.45.2 --- lms/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/__init__.py b/lms/__init__.py index 99ca0c3d..79387d42 100644 --- a/lms/__init__.py +++ b/lms/__init__.py @@ -1 +1 @@ -__version__ = "2.45.1" +__version__ = "2.45.2"