From 7dccef6b10ce30b49557328f0d77f2ccde3237e9 Mon Sep 17 00:00:00 2001 From: Om vataliya Date: Fri, 9 Jan 2026 23:45:29 +0530 Subject: [PATCH] fix: Add missing /lms prefix to assignment submission notification links Fixes #1969 - Added /lms prefix to notification link in lms_assignment_submission.py - Added /lms prefix to assessment URL in utils.py - Ensures consistent routing with other notification links (courses, billing, etc.) - Resolves 404 errors when users click 'View' on assignment submission notifications --- .../lms_assignment_submission.py | 8 +------- lms/lms/utils.py | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py index 52b08357..1d64b952 100644 --- a/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py +++ b/lms/lms/doctype/lms_assignment_submission/lms_assignment_submission.py @@ -73,13 +73,7 @@ class LMSAssignmentSubmission(Document): "for_user": self.owner, "from_user": self.evaluator, "type": "Alert", - "link": f"/assignment-submission/{self.assignment}/{self.name}", - } - ) - make_notification_logs(notification, [self.member]) - - -@frappe.whitelist() + "link": f"/lms/assignment-submission/{self.assignment}/{self.name}", def upload_assignment( assignment_attachment=None, answer=None, diff --git a/lms/lms/utils.py b/lms/lms/utils.py index 3d404b6e..1f5ea904 100644 --- a/lms/lms/utils.py +++ b/lms/lms/utils.py @@ -1269,7 +1269,7 @@ def get_assignment_details(assessment, member): assessment.edit_url = f"/assignments/{assessment.assessment_name}" submission_name = existing_submission if existing_submission else "new-submission" - assessment.url = f"/assignment-submission/{assessment.assessment_name}/{submission_name}" + assessment.url = f"/lms/assignment-submission/{assessment.assessment_name}/{submission_name}" return assessment