From f021ddd84c9702598309dee09d945c6823161d67 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Fri, 6 Feb 2026 17:08:49 +0530 Subject: [PATCH] chore: fixed type annotations for doc_event methods --- lms/lms/api.py | 2 +- .../lms_certificate_request/lms_certificate_request.py | 4 ++-- lms/lms/payments.py | 2 +- lms/lms/user.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lms/lms/api.py b/lms/lms/api.py index 2ba2a0ee..ef2f216d 100644 --- a/lms/lms/api.py +++ b/lms/lms/api.py @@ -488,7 +488,7 @@ def update_lesson_index(lesson: str, sourceChapter: str, targetChapter: str, idx update_target_chapter(lesson, targetChapter, idx) -def update_source_chapter(lesson: str, chapter: str, idx: int, hasMoved=False): +def update_source_chapter(lesson: str, chapter: str, idx: int, hasMoved: bool = False): lessons = frappe.get_all( "Lesson Reference", { diff --git a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py index b9fc97fb..4e7b93b5 100644 --- a/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py +++ b/lms/lms/doctype/lms_certificate_request/lms_certificate_request.py @@ -199,7 +199,7 @@ def create_event(eval: dict): return event -def add_participants(eval: dict, event: frappe._dict): +def add_participants(eval: dict, event: Document): participants = [eval.member, eval.evaluator] for participant in participants: contact_name = frappe.db.get_value("Contact", {"email_id": participant}, "name") @@ -216,7 +216,7 @@ def add_participants(eval: dict, event: frappe._dict): ).save() -def update_meeting_details(eval: dict, event: frappe._dict, calendar: str): +def update_meeting_details(eval: dict, event: Document, calendar: str): event.reload() event.update( { diff --git a/lms/lms/payments.py b/lms/lms/payments.py index 1cc3c78d..35aac722 100644 --- a/lms/lms/payments.py +++ b/lms/lms/payments.py @@ -73,7 +73,7 @@ def get_payment_link( return url -def create_order(payment_gateway: str, payment_details: dict, controller): +def create_order(payment_gateway: str, payment_details: dict, controller: object): if payment_gateway != "Razorpay": return diff --git a/lms/lms/user.py b/lms/lms/user.py index be33b110..4ca5cb64 100644 --- a/lms/lms/user.py +++ b/lms/lms/user.py @@ -85,7 +85,7 @@ def set_country_from_ip(login_manager: object = None, user: str = None): return -def on_login(): +def on_login(login_manager): default_app = frappe.db.get_single_value("System Settings", "default_app") if default_app == "lms": frappe.local.response["home_page"] = get_lms_route()