From f9d74637105d2ac77fa00b823dd531178c4d44b9 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Fri, 5 Dec 2025 11:03:38 +0530 Subject: [PATCH] test: removed tests for old batch and exercises --- frontend/src/components/Assignment.vue | 3 + frontend/src/components/Notes/Notes.vue | 3 + .../lms_enrollment/test_lms_enrollment.py | 63 +++---------------- .../doctype/lms_exercise/test_lms_exercise.py | 48 +------------- 4 files changed, 17 insertions(+), 100 deletions(-) diff --git a/frontend/src/components/Assignment.vue b/frontend/src/components/Assignment.vue index 6c97c8d8..c8ad35f6 100644 --- a/frontend/src/components/Assignment.vue +++ b/frontend/src/components/Assignment.vue @@ -179,6 +179,9 @@ " :editable="true" :fixedMenu="true" + :uploadArgs="{ + private: true, + }" editorClass="prose-sm max-w-none border-b border-x bg-surface-gray-2 rounded-b-md py-1 px-2 min-h-[7rem]" /> diff --git a/frontend/src/components/Notes/Notes.vue b/frontend/src/components/Notes/Notes.vue index 39439f7a..a6ceabc6 100644 --- a/frontend/src/components/Notes/Notes.vue +++ b/frontend/src/components/Notes/Notes.vue @@ -7,6 +7,9 @@ :placeholder="__('Make notes for quick revision. Press / for menu.')" @change="(val: string) => updateNoteText(val)" :editable="true" + :uploadArgs="{ + private: true, + }" editorClass="prose prose-sm min-h-[200px] max-w-none" /> diff --git a/lms/lms/doctype/lms_enrollment/test_lms_enrollment.py b/lms/lms/doctype/lms_enrollment/test_lms_enrollment.py index 8a077834..22e7fb4c 100644 --- a/lms/lms/doctype/lms_enrollment/test_lms_enrollment.py +++ b/lms/lms/doctype/lms_enrollment/test_lms_enrollment.py @@ -9,60 +9,15 @@ from lms.lms.doctype.lms_course.test_lms_course import new_course, new_user class TestLMSEnrollment(unittest.TestCase): - def setUp(self): - frappe.db.delete("LMS Enrollment") - frappe.db.delete("LMS Batch Old") - frappe.db.delete("LMS Course Mentor Mapping") - frappe.db.delete("User", {"email": ("like", "%@test.com")}) - - def new_course_batch(self): - course = new_course("Test Course") - - new_user("Test Mentor", "mentor@test.com") - # without this, the creating batch will fail - course.add_mentor("mentor@test.com") - - frappe.session.user = "mentor@test.com" - - batch = frappe.get_doc( - { - "doctype": "LMS Batch Old", - "name": "test-batch", - "title": "Test Batch", - "course": course.name, - } - ) - batch.insert(ignore_permissions=True) - - frappe.session.user = "Administrator" - return course, batch - - def add_membership(self, batch_name, member_name, course, member_type="Student"): - doc = frappe.get_doc( - { - "doctype": "LMS Enrollment", - "batch_old": batch_name, - "member": member_name, - "member_type": member_type, - "course": course, - } - ) - doc.insert() - return doc - def test_membership(self): - course, batch = self.new_course_batch() - member = new_user("Test", "test01@test.com") - membership = self.add_membership(batch.name, member.name, course.name) + course = new_course("Test Enrollment") + enrollment = frappe.new_doc("LMS Enrollment") + enrollment.course = course.name + enrollment.member = frappe.session.user - assert membership.course == course.name - assert membership.member_name == member.full_name + enrollment.save() - def test_membership_change_role(self): - course, batch = self.new_course_batch() - member = new_user("Test", "test01@test.com") - membership = self.add_membership(batch.name, member.name, course.name) - - # it should be possible to change role - membership.role = "Admin" - membership.save() + self.assertEqual(enrollment.course, course.name) + self.assertEqual(enrollment.member, "Administrator") + frappe.db.delete("LMS Enrollment", enrollment.name) + frappe.db.delete("LMS Course", course.name) diff --git a/lms/lms/doctype/lms_exercise/test_lms_exercise.py b/lms/lms/doctype/lms_exercise/test_lms_exercise.py index 766cd760..76ede444 100644 --- a/lms/lms/doctype/lms_exercise/test_lms_exercise.py +++ b/lms/lms/doctype/lms_exercise/test_lms_exercise.py @@ -3,52 +3,8 @@ import unittest -import frappe - -from lms.lms.doctype.lms_course.test_lms_course import new_course +# import frappe class TestLMSExercise(unittest.TestCase): - def new_exercise(self): - course = new_course("Test Course") - member = frappe.get_doc( - { - "doctype": "LMS Enrollment", - "course": course.name, - "member": frappe.session.user, - } - ) - member.insert() - e = frappe.get_doc( - { - "doctype": "LMS Exercise", - "name": "test-problem", - "course": course.name, - "title": "Test Problem", - "description": "draw a circle", - "code": "# draw a single cicle", - "answer": ("# draw a single circle\n" + "circle(100, 100, 50)"), - } - ) - e.insert() - return e - - def test_exercise(self): - e = self.new_exercise() - assert e.get_user_submission() is None - - def test_exercise_submission(self): - e = self.new_exercise() - submission = e.submit("circle(100, 100, 50)") - assert submission is not None - assert submission.exercise == e.name - assert submission.course == e.course - - user_submission = e.get_user_submission() - assert user_submission is not None - assert user_submission.name == submission.name - - def tearDown(self): - frappe.db.delete("LMS Enrollment") - frappe.db.delete("Exercise Submission") - frappe.db.delete("LMS Exercise") + pass