From 735a3f4b0052c1a38edfb664274a925412889955 Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 9 Mar 2026 11:34:28 +0530 Subject: [PATCH 1/2] fix: misc issues --- frontend/src/components/Assignment.vue | 2 ++ frontend/src/pages/Batches/components/BatchOverlay.vue | 4 ++++ lms/hooks.py | 5 ++--- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/frontend/src/components/Assignment.vue b/frontend/src/components/Assignment.vue index 38a73a26..a6e196c8 100644 --- a/frontend/src/components/Assignment.vue +++ b/frontend/src/components/Assignment.vue @@ -421,6 +421,8 @@ const canGradeSubmission = computed(() => { const canModifyAssignment = computed(() => { if (canGradeSubmission.value) { return true + } else if (props.submissionName == 'new') { + return true } else if ( submissionResource.doc?.owner == user.data?.name && submissionResource.doc?.status == 'Not Graded' diff --git a/frontend/src/pages/Batches/components/BatchOverlay.vue b/frontend/src/pages/Batches/components/BatchOverlay.vue index d7b88e00..1f97dab1 100644 --- a/frontend/src/pages/Batches/components/BatchOverlay.vue +++ b/frontend/src/pages/Batches/components/BatchOverlay.vue @@ -151,6 +151,10 @@ const enrollInBatch = () => { }, }) }, + onError(err) { + toast.error(__(err.messages?.[0] || err)) + console.error(err) + }, } ) } diff --git a/lms/hooks.py b/lms/hooks.py index 3fc60642..041d1f7a 100644 --- a/lms/hooks.py +++ b/lms/hooks.py @@ -8,17 +8,16 @@ app_publisher = "Frappe" app_description = "Open Source Learning Management System built with Frappe Framework" app_icon_url = "/assets/lms/images/lms-logo.png" app_icon_title = "Learning" +app_icon_route = "/lms" app_color = "grey" app_email = "jannat@frappe.io" app_license = "AGPL" def get_lms_path(): - return (frappe.conf.get("lms_path") or "lms").strip("/") + return (frappe.conf.get("lms_path") if frappe.conf else "lms").strip("/") -app_icon_route = f"/{get_lms_path()}" - # Includes in # ------------------ From f11059524fa29838e8451f4dcb620ed018db917c Mon Sep 17 00:00:00 2001 From: Jannat Patel Date: Mon, 9 Mar 2026 11:54:16 +0530 Subject: [PATCH 2/2] fix: lms dynamic path fetching --- frontend/package.json | 2 -- lms/hooks.py | 5 ++++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/frontend/package.json b/frontend/package.json index d838d5e2..d94a0be5 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -27,8 +27,6 @@ "@editorjs/table": "2.4.2", "@vueuse/core": "^14.1.0", "ace-builds": "1.36.2", - "apexcharts": "4.3.0", - "chart.js": "4.4.1", "codemirror": "6.0.1", "dayjs": "1.11.10", "dompurify": "3.2.6", diff --git a/lms/hooks.py b/lms/hooks.py index 041d1f7a..a96ff6d3 100644 --- a/lms/hooks.py +++ b/lms/hooks.py @@ -15,7 +15,10 @@ app_license = "AGPL" def get_lms_path(): - return (frappe.conf.get("lms_path") if frappe.conf else "lms").strip("/") + path = "lms" + if frappe.conf and frappe.conf.get("lms_path"): + path = frappe.conf.get("lms_path") + return path.strip("/") # Includes in