diff --git a/.github/helper/install.sh b/.github/helper/install.sh index 21bb9d9a..9cec55c7 100644 --- a/.github/helper/install.sh +++ b/.github/helper/install.sh @@ -11,6 +11,7 @@ cd ./frappe-bench || exit bench -v setup requirements echo "Setting Up LMS App..." +bench get-app "https://github.com/frappe/payments" bench get-app lms "${GITHUB_WORKSPACE}" echo "Setting Up Sites & Database..." diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bfe2b8b4..66d9b00a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,6 +62,9 @@ jobs: mkdir -p ~/bench-cache (cd && tar czf ~/bench-cache/bench.tgz frappe-bench) fi + - name: add payments app to bench + working-directory: /home/runner/frappe-bench + run: bench get-app https://github.com/frappe/payments - name: add lms app to bench working-directory: /home/runner/frappe-bench run: bench get-app lms $GITHUB_WORKSPACE diff --git a/cypress/e2e/course_creation.cy.js b/cypress/e2e/course_creation.cy.js index b5f5ae73..b7a67bc9 100644 --- a/cypress/e2e/course_creation.cy.js +++ b/cypress/e2e/course_creation.cy.js @@ -104,16 +104,18 @@ describe("Course Creation", () => { cy.closeOnboardingModal(); cy.url().should("include", "/lms/courses"); - cy.get(".grid a:first").within(() => { - cy.get("div").contains("Test Course"); - cy.get("div").contains( - "Test Course Short Introduction to test the UI" - ); - cy.get(".bg-cover") - .invoke("css", "background-image") - .should("include", "/files/profile"); - }); - cy.get(".grid a:first").click(); + cy.get("div") + .contains("Test Course") + .closest("a") + .within(() => { + cy.get("div").contains( + "Test Course Short Introduction to test the UI" + ); + cy.get(".bg-cover") + .invoke("css", "background-image") + .should("include", "/files/profile"); + }); + cy.get("div").contains("Test Course").closest("a").click(); cy.url().should("include", "/lms/courses/test-course"); cy.get("div").contains("Test Course"); cy.get("div").contains("Test Course Short Introduction to test the UI"); @@ -142,7 +144,6 @@ describe("Course Creation", () => { ); // Add Discussion - cy.get("span").contains("Community").click(); cy.button("New Question").click(); cy.wait(500); cy.get("[data-dismissable-layer]").within(() => { diff --git a/frontend/src/App.vue b/frontend/src/App.vue index 697aa346..25f6d8de 100644 --- a/frontend/src/App.vue +++ b/frontend/src/App.vue @@ -1,6 +1,6 @@ -
+
{ } const batchMenu = computed(() => { + if (!batch.data?.certification && !canMakeAnnouncement()) { + return [] + } let options = [ { label: __('Generate Certificates'), diff --git a/frontend/src/pages/Batches/components/BatchOverlay.vue b/frontend/src/pages/Batches/components/BatchOverlay.vue index 1f97dab1..73777cee 100644 --- a/frontend/src/pages/Batches/components/BatchOverlay.vue +++ b/frontend/src/pages/Batches/components/BatchOverlay.vue @@ -56,7 +56,7 @@
-
+
-