Commit Graph

1252 Commits

Author SHA1 Message Date
Jannat Patel 26623ecc25 Merge pull request #2260 from pateljannat/issues-216
fix: misc ui improvements
2026-03-26 16:27:24 +05:30
Jannat Patel 5b50701b3b fix: ui improvements in batch feedback and evaluator slots 2026-03-26 15:59:02 +05:30
Jannat Patel 71c13d634c fix: enhancements in quiz 2026-03-26 15:58:20 +05:30
Hussain Nagaria e3a70a04a3 Merge branch 'develop' into misc/fixes 2026-03-25 10:23:55 +05:30
Hussain Nagaria ecc01825c0 fix: move to correct line 2026-03-24 15:33:58 +05:30
Hussain Nagaria 681923e3f7 chore: ignore semgrep on batch details whitelisted method 2026-03-24 15:29:15 +05:30
raizasafeel 89505eac7d fix(scorm): save_progress no longer impended by race condition 2026-03-24 15:27:08 +05:30
Hussain Nagaria e7d2594142 feat: show preview video in batch 2026-03-24 15:19:51 +05:30
Leo Daniel A f2807d3e38 fix: LiveCodeSession reference error and UI loading state (#2218)
* fix: LiveCodeSession reference error and UI loading state

* fix: remove trailing slash from livecode_url in LMS Settings and add patch to update existing records

* fix: remove reload function in patch file and update live_code_url default value by administrator

---------

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
2026-03-19 17:55:24 +05:30
Jannat Patel 0d39f1cce1 fix: certification should be visible by default in sidebar 2026-03-19 15:37:51 +05:30
raizasafeel dd8a0d4238 feat: add member modal, evaluator add refactor 2026-03-17 01:55:57 +05:30
Jannat Patel 61b3bd651d Merge pull request #2188 from pateljannat/quiz-navigation
feat: navigate between questions in quiz
2026-03-13 18:19:00 +05:30
Jannat Patel 747da123aa test: quiz submission 2026-03-13 11:57:55 +05:30
raizasafeel 8458985c28 test: test sync between evaluator doc and role 2026-03-12 17:05:33 +05:30
raizasafeel ba394926c5 fix: synched evaluator across roles and 'course evaluator' doctype 2026-03-12 17:05:26 +05:30
Jannat Patel 429d38f771 feat: navigate between questions in quiz 2026-03-12 16:50:02 +05:30
Jannat Patel 9820db329e fix: course deletion issues 2026-03-11 11:50:05 +05:30
Jannat Patel d68a362115 feat: settings for payment reminders 2026-03-10 18:44:28 +05:30
Jannat Patel c583ad72d1 fix: send payment reminders for incomplete batch payments only 2026-03-10 18:15:36 +05:30
Jannat Patel 82d9ea7efc fix: delete demo quiz and users when deleting demo data 2026-03-09 16:37:21 +05:30
Jannat Patel a6da65ab99 fix: dont capture progress of demo course for analytics 2026-03-09 16:22:21 +05:30
Jannat Patel 711d89b603 fix: exclude demo course count before showing persona 2026-03-06 17:51:40 +05:30
Jannat Patel 3889893b2f Merge branch 'develop' of https://github.com/frappe/lms into demo-data 2026-03-06 17:44:53 +05:30
Jannat Patel 7c20b9c728 ci: get payments app in ui tests 2026-03-06 17:00:03 +05:30
Jannat Patel 607103e40e feat: demo review and course progress 2026-03-05 21:41:34 +05:30
Raizaaa 112cc3ac9d Merge branch 'frappe:develop' into fix/payment 2026-03-05 02:07:41 +05:30
raizasafeel 5683fd5d7a fix: add get_field_meta function to get doctype field metadata 2026-03-05 02:03:24 +05:30
Jannat Patel 82f0bb40ef Merge branch 'main-hotfix' into develop 2026-03-04 20:49:45 +05:30
Jannat Patel 701814060d fix: delete event after deleting the live class 2026-03-04 20:35:51 +05:30
Jannat Patel 292b48fbac fix: do not link live class to event as event is already linked to live class 2026-03-04 18:08:55 +05:30
Jannat Patel 2e3baff401 refactor: live class controllers for better code reusability 2026-03-04 16:59:32 +05:30
Jannat Patel 8752f8038a Merge pull request #2156 from raizasafeel/fix/payment-gateway
fix(payment gateway): add delete functionality and field details
2026-03-04 11:01:38 +05:30
Jannat Patel c5bb852227 Merge pull request #2122 from ColoredCow/feature/google-meet
feat: Google Meet integration for Live Classes
2026-03-04 11:00:13 +05:30
Jannat Patel c77fdf55b3 Merge branch 'main' into main-hotfix 2026-03-04 10:22:29 +05:30
Vaibhav Rathore a29e1a58a4 fix: resolve server test failures for Google Meet integration
- Mock get_google_calendar_object in live class tests to prevent real
  Google API calls in CI (no OAuth tokens available)
- Fix on_trash to clear event link before deleting Event to avoid
  LinkExistsError
- Fix test query to avoid PostgreSQL-incompatible integer filter
- Add Google Settings setup to Google Meet Settings integration tests
2026-03-03 17:34:34 +05:30
Vaibhav Rathore f0d35ec1d1 fix: enable Google API in test setup to fix CI server tests
Google Calendar validation requires Google API to be enabled in Google
Settings. Without this, all LMS Live Class tests fail in CI with
"Enable Google API in Google Settings" error.
2026-03-03 15:56:34 +05:30
Vaibhav Rathore cd9a6831a7 fix: add type annotations and role validation to create_google_meet_live_class
Add type hints to match create_live_class signature. Add
frappe.only_for role check to prevent unauthorized access.
2026-03-03 15:56:33 +05:30
Vaibhav Rathore 4925c5bc45 refactor: extract shared helpers to reduce code duplication in lms_live_class
Extract _get_participants() and _build_event_description() to eliminate
duplicated participant-gathering and description-building logic across
Zoom and Google Meet code paths.
2026-03-03 15:56:33 +05:30
Vaibhav Rathore f5551603a5 fix: resolve ruff-format and prettier linting errors 2026-03-03 15:56:33 +05:30
Jannat Patel 4771ebbcfd fix: enrollment error during course progress 2026-03-03 12:48:51 +05:30
Jannat Patel d3a4c211db fix: do not accept json as input for certificate request event 2026-03-02 13:29:06 +05:30
raizasafeel 5ae5634753 fix(payment gateway): add missing removeAccount function 2026-03-02 13:02:06 +05:30
Jannat Patel f63a4a44a2 fix: support youtube watch links as preview links 2026-03-02 13:01:59 +05:30
raizasafeel b95a308f7a fix(payment gateway): include reqd, options, default, and description in fields 2026-03-02 12:10:31 +05:30
Jannat Patel 78c6bfea83 fix: if certificate is linked to a batch then don't validate course enrollment 2026-02-27 10:56:06 +05:30
Vaibhav Rathore 8ea178fcad refactor: remove manual attendance feature for Google Meet classes
Manual attendance marking is not required for Google Meet live classes.
This removes the ManualAttendance modal, the mark_manual_attendance API
endpoint, and associated tests.
2026-02-26 18:38:55 +05:30
Jannat Patel 975f06d956 feat: nudge students to complete their profile 2026-02-26 16:59:08 +05:30
Jannat Patel 87e588cd1f fix: misc permission issues 2026-02-26 15:48:21 +05:30
Vaibhav Rathore 08b6a9d091 fix: use str() instead of get_time_str() for time field comparison
get_time_str() expects a timedelta but batch start_time is a
datetime.time object, causing AttributeError on batch details page.
2026-02-25 17:05:38 +05:30
Vaibhav Rathore 4be47af3ef fix: skip conferencing provider validation on batch creation
Frappe sets Select field default to the first option ("Zoom") even
when the field isn't in the creation form. Skip validation for new
batches since conferencing is configured after creation.
2026-02-25 16:59:23 +05:30