MIDNIGHT/enlight-lms
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: reindex lessons after deletion to prevent stale form state

Browse Source 
When a lesson was deleted, the remaining lessons' idx values were not resequenced. This caused Add Lesson to navigate to an existing lesson instead of creating a new one, showing stale data in the form.
This commit is contained in:
Adarsh Singh
2026-01-24 17:04:38 +05:30
parent b429fb2e47
commit 53c77f9070
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lms/lms/api.py
View File

@@ -476,15 +476,17 @@ def delete_sidebar_item(webpage):
@frappe.whitelist()
def delete_lesson(lesson, chapter):
# Delete Reference
chapter = frappe.get_doc("Course Chapter", chapter)
chapter.lessons = [row for row in chapter.lessons if row.lesson != lesson]
chapter.save()
lessons = frappe.get_all(
"Lesson Reference",
{"parent": chapter},
pluck="lesson",
order_by="idx",
)
lessons.remove(lesson)
frappe.db.delete("Lesson Reference", {"parent": chapter, "lesson": lesson})
update_index(lessons, chapter)
# Delete progress
frappe.db.delete("LMS Course Progress", {"lesson": lesson})
# Delete Lesson
frappe.db.delete("Course Lesson", lesson)