MIDNIGHT/frappe-lms
2
0
Fork 0
mirror of https://github.com/frappe/lms.git synced 2026-04-19 22:52:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2171 from pateljannat/issues-206

Browse Source 
fix: misc issues
This commit is contained in:
Jannat Patel
2026-03-09 12:20:28 +05:30
committed by GitHub
parent 0a587e5598 f11059524f
commit 68d69d5ccd
4 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/package.json
View File

@@ -27,8 +27,6 @@
"@editorjs/table": "2.4.2", "@editorjs/table": "2.4.2",
"@vueuse/core": "^14.1.0", "@vueuse/core": "^14.1.0",
"ace-builds": "1.36.2", "ace-builds": "1.36.2",
"apexcharts": "4.3.0",
"chart.js": "4.4.1",
"codemirror": "6.0.1", "codemirror": "6.0.1",
"dayjs": "1.11.10", "dayjs": "1.11.10",
"dompurify": "3.2.6", "dompurify": "3.2.6",

2
frontend/src/components/Assignment.vue
View File

@@ -421,6 +421,8 @@ const canGradeSubmission = computed(() => {
const canModifyAssignment = computed(() => { const canModifyAssignment = computed(() => {
if (canGradeSubmission.value) { if (canGradeSubmission.value) {
return true return true
} else if (props.submissionName == 'new') {
return true
} else if ( } else if (
submissionResource.doc?.owner == user.data?.name && submissionResource.doc?.owner == user.data?.name &&
submissionResource.doc?.status == 'Not Graded' submissionResource.doc?.status == 'Not Graded'

4
frontend/src/pages/Batches/components/BatchOverlay.vue
View File

@@ -151,6 +151,10 @@ const enrollInBatch = () => {
}, },
}) })
}, },
onError(err) {
toast.error(__(err.messages?.[0] || err))
console.error(err)
},
} }
) )
} }

8
lms/hooks.py
View File

@@ -8,17 +8,19 @@ app_publisher = "Frappe"
app_description = "Open Source Learning Management System built with Frappe Framework" app_description = "Open Source Learning Management System built with Frappe Framework"
app_icon_url = "/assets/lms/images/lms-logo.png" app_icon_url = "/assets/lms/images/lms-logo.png"
app_icon_title = "Learning" app_icon_title = "Learning"
app_icon_route = "/lms"
app_color = "grey" app_color = "grey"
app_email = "jannat@frappe.io" app_email = "jannat@frappe.io"
app_license = "AGPL" app_license = "AGPL"
def get_lms_path(): def get_lms_path():
return (frappe.conf.get("lms_path") or "lms").strip("/") path = "lms"
if frappe.conf and frappe.conf.get("lms_path"):
path = frappe.conf.get("lms_path")
return path.strip("/")
app_icon_route = f"/{get_lms_path()}"
# Includes in <head> # Includes in <head>
# ------------------ # ------------------