MIDNIGHT/frappe-lms
2
0
Fork 0
mirror of https://github.com/frappe/lms.git synced 2026-04-19 22:52:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: save export zip as private

Browse Source
This commit is contained in:
Jannat Patel
2026-04-02 17:10:40 +05:30
parent 564d10feb6
commit c0df21c076
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lms/lms/course_import_export.py
View File

@@ -184,7 +184,7 @@ def create_course_zip(
instructors,
evaluator,
)
final_path = move_zip_to_public(tmp_path, zip_filename)
final_path = move_zip_to_private(tmp_path, zip_filename)
schedule_file_deletion(final_path, delay_seconds=600) # 10 minutes
serve_zip(final_path, zip_filename)
except Exception as e:
@@ -260,8 +260,8 @@ def write_assets(zip_file, assets):
zip_file.write(file_path, f"assets/{safe_filename}")
def move_zip_to_public(tmp_path, zip_filename):
final_path = os.path.join(frappe.get_site_path("public", "files"), zip_filename)
def move_zip_to_private(tmp_path, zip_filename):
final_path = os.path.join(frappe.get_site_path("private", "files"), zip_filename)
shutil.move(tmp_path, final_path)
return final_path
@@ -279,10 +279,6 @@ def write_evaluator_json(zip_file, evaluator):
def serve_zip(final_path, zip_filename):
site_path = frappe.get_site_path()
if not os.path.abspath(final_path).startswith(site_path):
frappe.throw(_("Invalid file path"))
if not os.path.exists(final_path) or not os.path.isfile(final_path):
frappe.throw(_("File not found"))